Code analysis Dialog UI improvements#21451
Conversation
There was a problem hiding this comment.
Pull request overview
Improves the Code Analysis dialog UX by updating how rule enablement is represented in the UI, preventing focus-stealing to the output channel after saving/closing, and marking the Code Analysis dialog tab as a Preview feature.
Changes:
- Replace per-rule checkboxes with a checkmark indicator in the Code Analysis rules table.
- Stop forcing the output channel to show when saving with “close after save”.
- Update localization/title strings to display “Code Analysis (Preview)” and add new localized labels for rule enabled/disabled.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| localization/xliff/vscode-mssql.xlf | Updates/introduces localized source strings (Preview title; rule enabled/disabled labels). |
| extensions/mssql/src/reactviews/pages/CodeAnalysis/codeAnalysis.tsx | Swaps rule checkbox UI for a checkmark indicator and adds styling/labels. |
| extensions/mssql/src/reactviews/common/locConstants.ts | Adds ruleEnabled / ruleDisabled localized strings for the React view. |
| extensions/mssql/src/constants/locConstants.ts | Changes Code Analysis panel title to “Code Analysis (Preview)”. |
| extensions/mssql/src/codeAnalysis/codeAnalysisWebViewController.ts | Removes output channel focus change when closing after save. |
| extensions/mssql/l10n/bundle.l10n.json | Adds new keys and updates Code Analysis title string for runtime localization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PR Changes
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #21451 +/- ##
==========================================
- Coverage 72.84% 72.84% -0.01%
==========================================
Files 325 325
Lines 96454 96455 +1
Branches 5411 5411
==========================================
- Hits 70262 70261 -1
- Misses 26192 26194 +2
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "sqlDatabaseProjects.createProjectFromDatabase": "Create Project From Database", | ||
| "sqlDatabaseProjects.updateProjectFromDatabase": "Update Project From Database", | ||
| "sqlDatabaseProjects.configureCodeAnalysisSettings": "Code Analysis Settings (Preview)", | ||
| "sqlDatabaseProjects.configureCodeAnalysisSettings": "Code Analysis Settings", |
There was a problem hiding this comment.
I thought we were doing a preview release for this feature in March. Is this not the case?
There was a problem hiding this comment.
Hey @kburtram , I got this Go from PM, "since the code is pretty low-risk and stable as-is, we are jumping to GA directly". But we can still discuss about it today and if everyone is not agreed with the decisions, I can simple add the preview tag back :)
Description
This PR:
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines