Skip to content

Code analysis Dialog UI improvements#21451

Merged
ssreerama merged 5 commits into
mainfrom
sai/mar/ca_checkboxes_iutputchannel
Mar 5, 2026
Merged

Code analysis Dialog UI improvements#21451
ssreerama merged 5 commits into
mainfrom
sai/mar/ca_checkboxes_iutputchannel

Conversation

@ssreerama
Copy link
Copy Markdown
Contributor

@ssreerama ssreerama commented Mar 4, 2026

Description

This PR:

  • Replaces rule checkboxes with check marks
  • Removes focus to output channel after closes the dialog on code analysis save
  • removing preview tag for the code analysis option

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

image

CA__Check_outputChannelFocus

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the Code Analysis dialog UX by updating how rule enablement is represented in the UI, preventing focus-stealing to the output channel after saving/closing, and marking the Code Analysis dialog tab as a Preview feature.

Changes:

  • Replace per-rule checkboxes with a checkmark indicator in the Code Analysis rules table.
  • Stop forcing the output channel to show when saving with “close after save”.
  • Update localization/title strings to display “Code Analysis (Preview)” and add new localized labels for rule enabled/disabled.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
localization/xliff/vscode-mssql.xlf Updates/introduces localized source strings (Preview title; rule enabled/disabled labels).
extensions/mssql/src/reactviews/pages/CodeAnalysis/codeAnalysis.tsx Swaps rule checkbox UI for a checkmark indicator and adds styling/labels.
extensions/mssql/src/reactviews/common/locConstants.ts Adds ruleEnabled / ruleDisabled localized strings for the React view.
extensions/mssql/src/constants/locConstants.ts Changes Code Analysis panel title to “Code Analysis (Preview)”.
extensions/mssql/src/codeAnalysis/codeAnalysisWebViewController.ts Removes output channel focus change when closing after save.
extensions/mssql/l10n/bundle.l10n.json Adds new keys and updates Code Analysis title string for runtime localization.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread localization/xliff/vscode-mssql.xlf Outdated
Comment thread localization/xliff/vscode-mssql.xlf
Comment thread extensions/mssql/src/reactviews/pages/CodeAnalysis/codeAnalysis.tsx Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 4, 2026

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 6391 KB 6390 KB ⚪ -1 KB ( 0% )
sql-database-projects VSIX 7024 KB 7024 KB ⚪ 0 KB ( 0% )
data-workspace VSIX 535 KB 535 KB ⚪ 0 KB ( 0% )

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread localization/xliff/sql-database-projects.xlf
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.84%. Comparing base (45f5fe6) to head (bb5dbd4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nsions/mssql/src/reactviews/common/locConstants.ts 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21451      +/-   ##
==========================================
- Coverage   72.84%   72.84%   -0.01%     
==========================================
  Files         325      325              
  Lines       96454    96455       +1     
  Branches     5411     5411              
==========================================
- Hits        70262    70261       -1     
- Misses      26192    26194       +2     
Files with missing lines Coverage Δ
.../src/codeAnalysis/codeAnalysisWebViewController.ts 92.35% <ø> (-0.03%) ⬇️
...nsions/mssql/src/reactviews/common/locConstants.ts 24.74% <0.00%> (-0.02%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread localization/xliff/vscode-mssql.xlf
Comment thread localization/xliff/sql-database-projects.xlf
"sqlDatabaseProjects.createProjectFromDatabase": "Create Project From Database",
"sqlDatabaseProjects.updateProjectFromDatabase": "Update Project From Database",
"sqlDatabaseProjects.configureCodeAnalysisSettings": "Code Analysis Settings (Preview)",
"sqlDatabaseProjects.configureCodeAnalysisSettings": "Code Analysis Settings",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were doing a preview release for this feature in March. Is this not the case?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kburtram , I got this Go from PM, "since the code is pretty low-risk and stable as-is, we are jumping to GA directly". But we can still discuss about it today and if everyone is not agreed with the decisions, I can simple add the preview tag back :)

@ssreerama ssreerama merged commit 2c4529c into main Mar 5, 2026
7 checks passed
@ssreerama ssreerama deleted the sai/mar/ca_checkboxes_iutputchannel branch March 5, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Closing (saving) the code analysis settings steals terminal focus to "output" panel [Bug]: Checkboxes on individual rules can't be toggled

5 participants