Add mssql_dab show flow and improve tool descripiton#21511
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a show flow to the mssql_dab Copilot tool so it can open the Data API Builder (DAB) view for a specified connection, and aligns the tool contract/schema with the schema-designer tool pattern.
Changes:
- Added
mssql_dab.showoperation (opens DAB view from a providedconnectionId) and wired it throughMainController. - Updated DAB tool contract/schema + internal change shape (
actions→enabledActions) and adjusted handler validation accordingly. - Added/updated localization strings and unit tests to cover the new behavior and updated schema expectations.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| localization/xliff/vscode-mssql.xlf | Adds new trans-units for DAB tool messaging (show success + error guidance). |
| extensions/mssql/l10n/bundle.l10n.json | Adds corresponding VS Code l10n bundle entries for new DAB strings. |
| extensions/mssql/src/constants/locConstants.ts | Introduces new localized strings used by mssql_dab show/error paths. |
| extensions/mssql/src/copilot/tools/dabTool.ts | Implements show operation, injects dependencies, and uses localized messages. |
| extensions/mssql/src/controllers/mainController.ts | Registers DabTool with required dependencies and adds openDabDesigner. |
| extensions/mssql/package.json | Updates mssql_dab tool manifest description and input schema (adds show, uses top-level object schema). |
| extensions/mssql/src/sharedInterfaces/dab.ts | Renames DAB change field to enabledActions for set_entity_actions. |
| extensions/mssql/src/reactviews/pages/SchemaDesigner/schemaDesignerRpcHandlers.ts | Updates DAB change application to validate/apply enabledActions; waits for initialization before serving state. |
| extensions/mssql/src/reactviews/pages/SchemaDesigner/schemaDesignerStateProvider.tsx | Exposes isInitializedRef + waitForInitialization on SchemaDesigner context. |
| extensions/mssql/src/reactviews/pages/SchemaDesigner/dab/dabContext.tsx | Passes initialization gating into DAB tool RPC handlers. |
| extensions/mssql/src/copilot/prompts.ts | Clarifies DAB prompt to reference “active schema designer” context. |
| extensions/mssql/test/unit/dabToolManifest.test.ts | Updates tests for new top-level schema shape and show/enabledActions changes. |
| extensions/mssql/test/unit/dabTool.test.ts | Adds unit coverage for show behavior and updated messages/field names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PR Changes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21511 +/- ##
==========================================
+ Coverage 72.54% 72.69% +0.15%
==========================================
Files 330 330
Lines 98008 98120 +112
Branches 5438 5446 +8
==========================================
+ Hits 71096 71326 +230
+ Misses 26912 26794 -118
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Adds a
showoperation tomssql_dabso Copilot can open the Data API Builder tab for a connection, and aligns the DAB tool contract with the existing schema-designer pattern.mssql_dab.showand wired it to open the DAB tab from aconnectionIdenabledActionsthe canonical DAB change fieldCode Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines