[SLG-0004]: metadata value attributes implementation#453
Merged
kukushechkin merged 17 commits intoMay 22, 2026
Merged
Conversation
kukushechkin
force-pushed
the
attributed-metadata-as-stringConvertible
branch
from
2a25dbc to
aa366c5
Compare
kukushechkin
force-pushed
the
attributed-metadata-as-stringConvertible
branch
3 times, most recently
from
f294301 to
9e7b525
Compare
kukushechkin
requested review from
FranzBusch and
weissi
and removed request for
FranzBusch
weissi
reviewed
Apr 30, 2026
kukushechkin
force-pushed
the
attributed-metadata-as-stringConvertible
branch
from
5500ff2 to
d87e798
Compare
kukushechkin
changed the title
CustomStringConvertibleCustomStringConvertible
kukushechkin
changed the title
CustomStringConvertibleCustomStringConvertible)
kukushechkin
force-pushed
the
attributed-metadata-as-stringConvertible
branch
2 times, most recently
from
5e053d0 to
d32532b
Compare
Contributor
Author
|
Sensitivity attribute and |
kukushechkin
changed the title
CustomStringConvertible)
kukushechkin
force-pushed
the
attributed-metadata-as-stringConvertible
branch
2 times, most recently
from
8f344ac to
86208e0
Compare
kukushechkin
force-pushed
the
attributed-metadata-as-stringConvertible
branch
from
968b9cb to
1197cb4
Compare
FranzBusch
reviewed
May 19, 2026
FranzBusch
approved these changes
May 22, 2026
Co-authored-by: Franz Busch <privat@franz-busch.de>
…thub.com/kukushechkin/swift-log into attributed-metadata-as-stringConvertible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal discussion thread: https://forums.swift.org/t/proposal-slg-0004-metadata-value-attributes-revision-2/86488
Add an extensible per-value attribute mechanism for metadata.
Motivation:
Metadata values in
swift-logare opaque strings by the time theLogHandlerreceives them. The call site oftenknows things about a value that the handler cannot infer — for example, whether the value should be redacted in
different environments.
Modifications:
AttributedStringCarrier: CustomStringConvertible-based mechanism toLogging.Result:
swift-logprovides an optional extensible mechanism for attaching attributes to metadata values.