[SLG-0004]: Revised Metadata value attributes + sensitivity attribute implementation#439
Closed
kukushechkin wants to merge 7 commits into
Closed
Conversation
kukushechkin
force-pushed
the
metadata-privacy-labels-external-attributes-slots
branch
5 times, most recently
from
f965af9 to
7a1a084
Compare
kukushechkin
changed the title
kukushechkin
changed the title
weissi
requested changes
Apr 21, 2026
Member
weissi
left a comment
weissi
left a comment
There was a problem hiding this comment.
The general idea and the implementation suggestion of using a fixed-sized inline slot is good.
But overall -1 because of these concerns:
- Major concern: Complete bifurcation of SwiftLog's core APIs. There's a new
LogMessagecalledLogEvent. There's new, duplicated metadata. This is essentially shipping a whole new version disguised as a feature addition. - Major concern: Bundles with sensitivity, privileges sensitivity & introduces unduly policy decisions regarding sensitivity into the core mechanism package. This one's easy to fix, remove anything relating to sensitivity from this proposal and create a new package
swift-log-sensitivity-attributesthat has no special privileges - Minor: Reveals too much about how the storage is implemented without reason
| } | ||
| ``` | ||
|
|
||
| #### Adopting attributed metadata in LogHandlers |
Member
There was a problem hiding this comment.
I think the adoption should not be this difficult. What we're proposing in disguise in this proposal is to essentially create a whole second API for SwiftLog. I do not think that this is a good direction.
kukushechkin
force-pushed
the
metadata-privacy-labels-external-attributes-slots
branch
from
7a1a084 to
44cf766
Compare
kukushechkin
force-pushed
the
metadata-privacy-labels-external-attributes-slots
branch
from
44cf766 to
c080098
Compare
kukushechkin
force-pushed
the
metadata-privacy-labels-external-attributes-slots
branch
from
c080098 to
b689899
Compare
Contributor
Author
|
Closed in favor of #453 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This is a revision of SLG-0004 previously discussed here. Note this is a draft, including more than just the proposal implementation.
Add an extensible per-value attribute mechanism for metadata, with sensitivity as the first attribute.
Motivation:
Metadata values in
swift-logare opaque strings by the time theLogHandlerreceives them. The call site oftenknows things about a value that the handler cannot infer — for example, whether the value should be redacted in
different environments.
Modifications:
AttributedMetadataValue-based mechanism toLogging.Sensitivityattribute to the newLoggingSensitivitytarget.OSLogHandleras an example of a concrete log handler taking advantage of theSensitivityattribute.Result:
swift-logprovides an optional extensible mechanism for attaching attributes to metadata values.swift-logprovides a commonSensitivityattribute and examples how to use it.