-
-
Notifications
You must be signed in to change notification settings - Fork 499
London | 26-ITP-May | Phaik Ling Soon | Sprint 1 | Form Controls #1375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,54 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Form</title> | ||
| </head> | ||
| <body> | ||
| <form action="results.html" method="GET"> | ||
| <div> | ||
| <h3> | ||
| Your T-Shirt Information | ||
| </h3> | ||
| <label for="name">Full Name:</label> | ||
| <input type="text" name="name" id="name" placeholder="First name" required> | ||
| <input type="text" name="name" id="name" placeholder="Last name" required> | ||
|
Comment on lines
+15
to
+16
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The spec has this requirement:
Note: Supposedly the form should only have one element for name input. i.e. no need separate input elements for last and first names. |
||
| </div> | ||
| <div> | ||
| <label for="email">Email:</label> | ||
| <input type="email" name="email" id="email" placeholder="Email" required> | ||
| </div> | ||
| <br> | ||
| Pick your favourite T-shirt colour: | ||
| <div> | ||
| <input type="radio" name="color" id="black" value="black"> | ||
| <label for="black">Mysterious Black</label> | ||
|
Comment on lines
+25
to
+26
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note: With this syntax, you would not need to introduce |
||
| <input type="radio" name="color" id="white" value="white"> | ||
| <label for="white">Bright White</label> | ||
| <input type="radio" name="color" id="violet" value="violet"> | ||
| <label for="violet">Nano Violet</label> | ||
| </div> | ||
| <div> | ||
| <label for="color">Colour Reference:</label> | ||
| <input type="color" name="color" id="color"> | ||
|
Comment on lines
+33
to
+34
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please note that adding form elements that are not defined in the specification is generally discouraged, as the implementation should remain aligned with the approved requirements. |
||
| </div> | ||
| <div> | ||
| <label for="T-shirtSize">T-shirt Size:</label> | ||
| <select name="T-shirtSize" id="T-shirtSize" id="T-shirt Size" required> | ||
| <option value="XS">XS</option> | ||
| <option value="S">S</option> | ||
| <option value="M">M</option> | ||
| <option value="L">L</option> | ||
| <option value="XL">XL</option> | ||
| <option value="XXL">XXL</option> | ||
| </select> | ||
|
Comment on lines
+38
to
+45
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you find out how to configure a |
||
| </div> | ||
| <br> | ||
| <button type="submit">Submit</button> | ||
| </form> | ||
| </body> | ||
| </html><!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec has this requirement: