London | 26-ITP-May | Phaik Ling Soon | Sprint 1 | Form Controls#1375
London | 26-ITP-May | Phaik Ling Soon | Sprint 1 | Form Controls#1375plsoongrace wants to merge 1 commit into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
plsoongrace
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
plsoongrace
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
plsoongrace
added
the
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
According to https://validator.w3.org/, there are errors in your code. Can you fix them? (You should address this issue first)
-
Can you improve the Lighthouse accessibility score from 93 to 100?
| <title>Form</title> | ||
| </head> | ||
| <body> | ||
| <form action="results.html" method="GET"> |
There was a problem hiding this comment.
The spec has this requirement:
Do not write a form action for this project.
| <input type="text" name="name" id="name" placeholder="First name" required> | ||
| <input type="text" name="name" id="name" placeholder="Last name" required> |
There was a problem hiding this comment.
The spec has this requirement:
What is the customer's name? I must collect this data and ensure it contains at least two non-space characters.
Note: Supposedly the form should only have one element for name input. i.e. no need separate input elements for last and first names.
| <input type="radio" name="color" id="black" value="black"> | ||
| <label for="black">Mysterious Black</label> |
There was a problem hiding this comment.
Note: With this syntax, you would not need to introduce id and for atttributes.
<label>
<input type="radio" name="..." value="...">
Radio button text
</label>
| <select name="T-shirtSize" id="T-shirtSize" id="T-shirt Size" required> | ||
| <option value="XS">XS</option> | ||
| <option value="S">S</option> | ||
| <option value="M">M</option> | ||
| <option value="L">L</option> | ||
| <option value="XL">XL</option> | ||
| <option value="XXL">XXL</option> | ||
| </select> |
There was a problem hiding this comment.
Can you find out how to configure a <select> element so that no option is selected by default, allowing the user to make an explicit choice?
| <label for="color">Colour Reference:</label> | ||
| <input type="color" name="color" id="color"> |
There was a problem hiding this comment.
Please note that adding form elements that are not defined in the specification is generally discouraged, as the implementation should remain aligned with the approved requirements.
cjyuan
added
Reviewed
2 participants
Self checklist
Changelist
I have created T-shirt Information under Form Controls.
Questions
I understand working on remote/ local machine, but I have challenges on checking my work whether it is successfully push to My GitHub account and the effective method to verify them.