-
-
Notifications
You must be signed in to change notification settings - Fork 499
London | 26-ITP-May | Edina Kurdi | Sprint 2 | Wireframe #1357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
edinakurdi
wants to merge
13
commits into
CodeYourFuture:main
Choose a base branch
from
edinakurdi:feature/wireframe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0a4362f
add placeholder text to wireframe articles
edinakurdi ceb09d7
update link styling, footer content and article links
edinakurdi 0515ff4
add space before footer link
edinakurdi aac134f
remove dubplicate padding on a
edinakurdi 6844c6c
clean up footer CSS
edinakurdi 8c86b9f
add colour variable to CSS root
edinakurdi 33516ee
add and style article images
edinakurdi c0c0492
add short descriptions of the three concepts
edinakurdi 7033ccf
fix footer according to criteria - fixed position
edinakurdi d5fb5bf
readme checks each criteria
edinakurdi 570b39b
add wireframe alt text
edinakurdi eef708e
merge the two main selectors into one
edinakurdi 56b4f2b
update footer to avoid overlaping with text in body
edinakurdi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another
mainselector at line 78. Consider merging the properties from both selectors into a singlemainrule to make them easier to find and maintain.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I consolidated the two.