London | 26-ITP-May | Edina Kurdi | Sprint 2 | Wireframe#1357
Open
edinakurdi wants to merge 13 commits into
Open
London | 26-ITP-May | Edina Kurdi | Sprint 2 | Wireframe#1357edinakurdi wants to merge 13 commits into
edinakurdi wants to merge 13 commits into
Conversation
- remove footer positioning - update footer placeholder text - simplify footer link styling - add article links, and adjust their styling
adjust footer link padding
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
edinakurdi
added
📅 Sprint 2
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
edinakurdi
added
Needs Review
5 tasks
cjyuan
added
Review in progress
cjyuan
reviewed
May 30, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code is free of error and well formatted, and page layout is solid. Well done.
I only have a few requests.
- Content becomes hard to read when they overlap (see pic). Can you address this issue?
Comment on lines
56
to
60
| main { | ||
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
| padding: 0 8rem; | ||
| } |
Contributor
There was a problem hiding this comment.
There is another main selector at line 78. Consider merging the properties from both selectors into a single main rule to make them easier to find and maintain.
Comment on lines
+40
to
+42
| <p> | ||
| A branch in Git is like an alternative version of a project. When several developers work on the same project, separate branches help them avoid overriding each other's work. These branches then can be merged into the main branch through a pull request. | ||
| </p> |
Contributor
There was a problem hiding this comment.
Breaking HTML text into multiple lines helps make the code easier to read, edit, and maintain while preserving the same rendered output.
VS Code formatter could be used to keep our code consistently formatted, including breaking long
lines of HTML text into multiple lines for easier editing and maintenance.
As a best practice, consider following this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.
Author
There was a problem hiding this comment.
I updated my VS code to automatically format using prettier and now the text is wrapped.
cjyuan
added
Reviewed
Author
|
responding to:
|
edinakurdi
removed
the
Reviewed
edinakurdi
added
the
Needs Review
Contributor
|
Changes look good. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Edited HTML and CSS to follow the wireframe, explained three concepts: wireframe, branch, and README
Questions