Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 2 | Wireframe #1303
+139
−82
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,84 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Wireframe</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
|
|
||
| <body> | ||
| <header> | ||
| <h1>Wireframe Coursework</h1> | ||
| <p>This is a wireframe assignment and the following articles answer specific questions.</p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="placeholder image" /> | ||
| <h2>Purpose of a README File</h2> | ||
| <p> | ||
| A README file provides a quick overview of what the project sets to achieve, | ||
| the likely uses and the guidelines of how others can contribute. | ||
| </p> | ||
| <details> | ||
| <summary>Read more</summary> | ||
| <p> | ||
| For more in-depth information, you can read the professional guide here: | ||
| <a href="https://www.makeareadme.com/" target="_blank" rel="noopener noreferrer"> | ||
| The Official README Guide | ||
| </a> | ||
| </p> | ||
| </details> | ||
| </article> | ||
|
|
||
| <article> | ||
| <img src="placeholder2.png" alt="wireframe image" /> | ||
| <h2>Purpose of Wireframe</h2> | ||
| <p> | ||
| A wireframe serves as a foundational blueprint or mental image of | ||
| a product. it has numerous functions, but most importantly, | ||
| a wireframe is often used in the early stages of web or app | ||
| development to prevent future,costly redesigns. | ||
| </p> | ||
| <details> | ||
| <summary>Read more</summary> | ||
| <p> | ||
| For more details on wireframing best practices and how they streamline | ||
| development, check out this guide: | ||
| <a href="https://www.uxpin.com/studio/blog/wireframing-guide/" target="_blank" rel="noopener noreferrer"> | ||
| The Ultimate Guide to Wireframing | ||
| </a> | ||
| </p> | ||
| </details> | ||
| </article> | ||
|
|
||
| <article> | ||
| <img src="Branch.png" alt="branch image" /> | ||
| <h2>Branching in Git</h2> | ||
| <p> | ||
| A branch represents an independent line of development in a Git repository, | ||
| allowing multiple developers to work on different features or bug fixes simultaneously | ||
| without affecting the main codebase until changes are ready to be merged. | ||
| </p> | ||
| <details> | ||
| <summary>Read more</summary> | ||
| <p> | ||
| For a deeper dive into how branching workflows operate and how to merge | ||
| your changes effectively, visit the official documentation: | ||
| <a href="https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell" target="_blank" | ||
| rel="noopener noreferrer"> | ||
| Git Branching Explained | ||
| </a> | ||
| </p> | ||
| </details> | ||
| </article> | ||
| </main> | ||
| <footer> | ||
| <p> | ||
| By Toluwalase Tiamiyu. | ||
| </p> | ||
| </footer> | ||
| </body> | ||
|
|
||
| </html> |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,89 +1,95 @@ | ||
| :root { | ||
| --color: #0056b3; | ||
| --paper: oklch(98 0 0); | ||
| --ink: color-mix(in oklab, var(--color) 5%, black); | ||
| --font: 100%/1.5 system-ui; | ||
| --space: clamp(6px, 6px + 2vw, 15px); | ||
| --line: 1px solid; | ||
| --container: 1280px; | ||
| } | ||
|
|
||
| body { | ||
| background: var(--paper); | ||
| color: var(--ink); | ||
| font: var(--font); | ||
| padding-bottom: 80px; | ||
| } | ||
| header { | ||
| text-align: center; | ||
| margin-bottom: calc(var(--space) * 2); | ||
| } | ||
| a { | ||
| max-width: fit-content; | ||
| text-decoration: underline; | ||
| } | ||
| img.svg { | ||
| width: 100%; | ||
| object-fit: cover; | ||
| } | ||
|
|
||
| footer { | ||
| position: fixed; | ||
| bottom: 0; | ||
| width: 100%; | ||
| text-align: center; | ||
| background: var(--paper); | ||
| padding: var(--space) 0; | ||
| border-top: var(--line); | ||
| } | ||
|
|
||
| main { | ||
| display: grid; | ||
| grid-template-columns: 1fr 1fr; | ||
| gap: var(--space); | ||
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
| } | ||
|
Comment on lines
40
to
+46
Contributor
There was a problem hiding this comment. There is another
Author
There was a problem hiding this comment. i have merged this also, hoping to see responses from you next review of my work
Contributor
There was a problem hiding this comment. I still see two |
||
|
|
||
| main > *:first-child { | ||
| grid-column: span 2; | ||
| } | ||
|
|
||
| article { | ||
| border: var(--line); | ||
| padding-bottom: var(--space); | ||
| padding-left: var(--space); | ||
| padding-right: var(--space); | ||
| text-align: left; | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: var(--space); | ||
| } | ||
| article img { | ||
| width: 100%; | ||
| display: block; | ||
| } | ||
|
|
||
| details p { | ||
| margin: 0; | ||
| padding-top: 10px; | ||
| padding-left: var(--space); | ||
| } | ||
|
|
||
| summary { | ||
| cursor: pointer; | ||
| padding: 10px; | ||
| background-color: #f4f4f4; | ||
| border-radius: 5px; | ||
| list-style: none; | ||
| font-weight: bold; | ||
| summary:hover { | ||
| background-color: #e0e0e0; | ||
| } | ||
|
|
||
| summary:focus-visible { | ||
| outline: 2px solid var(--color); | ||
| outline-offset: 2px; | ||
| } | ||
| } | ||
|
|
||
| details { | ||
| margin-top: 10px; | ||
| padding: 10px; | ||
| border: 1px solid #ddd; | ||
| border-radius: 5px; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still two
mainselectors in this file. Consider merging the properties from both selectors into a singlemainrule to make them easier to find and maintain.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have improved the grammar, typos and consistency of the html code, i have also merged the two main rules into one.