Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 2 | Wireframe by TTiamiyu · Pull Request #1303 · CodeYourFuture/Module-Onboarding

TTiamiyu · 2026-05-17T00:20:17Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I worked on the html and the css attributes,

netlify · 2026-05-17T00:20:22Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`d1d6f5b`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1c090f3644280008f6de9c
😎 Deploy Preview	https://deploy-preview-1303--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 91 (🟢 up 5 from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

cjyuan

In the wireframe, articles 2 and 3 are positioned below article 1. In your implementation, they appear to the right of article 1 instead (see pic).

In the wireframe, the "Read more" links have uniform padding space around the link. In your implementation, they have more right padding space.

Could you update the CSS so the page layout more closely matches the wireframe?

cjyuan · 2026-05-29T16:25:58Z

+        <a href="https://www.uxpin.com/studio/blog/wireframing-guide/" target="_blank" rel="noopener noreferrer">
+        The Ultimate Guide to Wireframing
+      </a>


Indentation is off. Why not enable auto format on VSCode or use its "Format document" feature?

…or and the others side by side

cjyuan · 2026-05-30T16:40:09Z

Can you check your deployed webpage to ensure it looks right?

https://deploy-preview-1303--cyf-onboarding-module.netlify.app/wireframe/

TTiamiyu · 2026-05-30T21:28:00Z

Can you check your deployed webpage to ensure it looks right?

https://deploy-preview-1303--cyf-onboarding-module.netlify.app/wireframe/

i noticed the texts in the article were not well padded on the left, the last commit i did addressed this specifically.

cjyuan

Page layout looks good.

I still noticed the following issue in the text content:

Some words are misspelled or use incorrect letter casing.

Could you show your HTML code to an AI tool and ask it to check for typo, consistency, and grammar?

cjyuan · 2026-05-30T21:48:15Z

There are still two main selectors in this file. Consider merging the properties from both selectors into a single main rule to make them easier to find and maintain.

i have improved the grammar, typos and consistency of the html code, i have also merged the two main rules into one.

…main rule merged.

cjyuan · 2026-05-31T10:48:43Z

Changes look good.

TTiamiyu added 3 commits May 16, 2026 23:50

Readme start

cb2bd46

Wireframe final

95d0161

spelling errors correction\

bcafd76

This comment has been minimized.

Sign in to view

TTiamiyu added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels May 17, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 17, 2026

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

TTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 17, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 17, 2026

TTiamiyu removed the Module-Onboarding The name of the module. label May 17, 2026

This comment has been minimized.

Sign in to view

TTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 17, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 17, 2026

TTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 17, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 17, 2026

TTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 17, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 17, 2026

Discribed alt

e76da36

cjyuan reviewed May 29, 2026

View reviewed changes

TTiamiyu added 3 commits May 30, 2026 16:39

Line 28{id attribute corrected}

dddd83f

structure and improve CSS layout for the articles, 1st article as maj…

8a7898b

…or and the others side by side

standardize HTML structure and improve readability, indentation fixed

8408e5b

TTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026

revert changes

4c932b1

TTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026

TTiamiyu added 2 commits May 30, 2026 16:51

revert formatting

9ac85b4

add extra line

970b380

TTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026

TTiamiyu added 3 commits May 30, 2026 21:50

fix: correct DOCTYPE declaration and clean up HTML structure

b8d3280

fix: update grid layout to use fixed column count for main section

6afd4b5

fix: refine image styling and adjust padding in article and details

b7132bc

TTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026

cjyuan reviewed May 30, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026

fix: improve README file descriptions and adjust image alt text. css …

f29e377

…main rule merged.

TTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 31, 2026

fix: remove redundant max-width declaration in main styling

d1d6f5b

Uh oh!

Conversation

TTiamiyu commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

netlify Bot commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan May 29, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

cjyuan commented May 30, 2026

Uh oh!

TTiamiyu commented May 30, 2026

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan May 30, 2026

Choose a reason for hiding this comment

Uh oh!

TTiamiyu May 31, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan commented May 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TTiamiyu commented May 17, 2026 •

edited

Loading

netlify Bot commented May 17, 2026 •

edited

Loading