fix: V1ConfigurationMapper - return empty list for null Dimensions to prevent ArgumentNullException#2743
Merged
tomkerkhove merged 1 commit intoMar 28, 2026
Conversation
|
Thank you for your contribution! 🙏 We will review it as soon as possible. |
tomkerkhove
approved these changes
Mar 27, 2026
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2743 in repo tomkerkhove/promitor |
…mensions to prevent ArgumentNullException
faf901b to
a1501e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression introduced in PR #2740 where the V1ConfigurationMapper returns null for AzureMetricConfiguration.Dimensions when the source has no dimensions configured. The AzureMetricConfigurationValidator calls .Any() on this property, which throws ArgumentNullException when it is null.
Root Cause
AutoMapper defaulted null collections to empty lists. The hand-written mapper preserved null, but downstream validators expect non-null collections.
Error
System.ArgumentNullException: Value cannot be null. (Parameter 'source') at System.Linq.Enumerable.Any[TSource](IEnumerable source) at AzureMetricConfigurationValidator.ValidateAzureMetricConfiguration(line 58)Fix
`diff
`
Verification