Add env for os#170
Draft
lucasbalieiro wants to merge 13 commits into
Draft
Conversation
…, BitcoinNetwork and HealthStatus in `shared`
…pcDiscovery.ts` to use `shared/`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to be merged after #169 and #162.
Another step toward Umbrel support and publication.
This PR adds support for determining the host OS from the
HOST_OSenvironment variable, for example:When
HOST_OSis set, the UI will prioritize that OS and hide the other options by default, while still allowing the user to manually select a different OS in case the detection is incorrect:If
HOST_OSis not set, the RPC probing introduced in #162 will also attempt to infer the OS from the RPC data.If both mechanisms fail and the OS cannot be determined, the user will see the default screen with all available OS options:
Once the Umbrel-specific integration lands, the
HOST_OSvariable will be automatically populated through the Umbreldocker-compose.yml.This PR extends the same behavior to the other supported operating systems so we can maintain a standardized UX and establish a cleaner foundation for future refactors.