Replaced unsafe ptr logic with chained split_at_mut in DenseMatrix an…#371
Open
jackpots28 wants to merge 3 commits into
Open
Replaced unsafe ptr logic with chained split_at_mut in DenseMatrix an…#371jackpots28 wants to merge 3 commits into
jackpots28 wants to merge 3 commits into
Conversation
…d DenseMatrixMutView
Collaborator
|
thank you! please run |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #371 +/- ##
===============================================
- Coverage 45.59% 44.15% -1.45%
===============================================
Files 93 94 +1
Lines 8034 8097 +63
===============================================
- Hits 3663 3575 -88
- Misses 4371 4522 +151 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
I updated the formatting and caught the issue with sort_by that clippy complained about. Test coverage is still slightly lower "src/linalg/basic/matrix.rs: 225/364" | "59.72% coverage, 5238/8771 lines covered", should I add some tests for more coverage? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d DenseMatrixMutView
Fixes #368
Checklist
Current behaviour
Changing DenseMatrix and DenseMatrixMutView that uses unsafe ptr arithmetic for generating mutable iterators
New expected behavior
DenseMatrix and DenseMatrixMutView continue to produce mutable iterators, but uses a "head" / "tail" method + split_at_mut function for iterating
Change logs
unsafepointer arithmetic inDenseMatrix/DenseMatrixMutViewmutable iterators with a safe, chainedsplit_at_mutimplementation to ensure memory safety without performance loss.