Skip to content

[Assassination] Deathstalker typo#11494

Merged
EvanMichaels merged 1 commit into
simulationcraft:midnightfrom
JannickMueller-Whispyr:fixds
Jun 2, 2026
Merged

[Assassination] Deathstalker typo#11494
EvanMichaels merged 1 commit into
simulationcraft:midnightfrom
JannickMueller-Whispyr:fixds

Conversation

@JannickMueller-Whispyr
Copy link
Copy Markdown
Contributor

Last APL update had a missing conditional

Last APL update had a missing conditional
Copilot AI review requested due to automatic review settings June 2, 2026 01:00
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adjusts the Assassination Rogue APL to allow Ambush and Mutilate to be used on low target counts whenever the Blindside talent is taken, by adding |talent.blindside to the existing condition.

Changes:

  • Added talent.blindside as an additional OR condition to the Ambush low-target action.
  • Added talent.blindside as an additional OR condition to the Mutilate low-target action.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
engine/class_modules/apl/rogue/assassination.simc Updated the simc APL conditions for Ambush/Mutilate to include the Blindside talent.
engine/class_modules/apl/apl_rogue.cpp Mirrored the same condition update in the C++ APL builder for consistency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@EvanMichaels EvanMichaels merged commit 58ad8b9 into simulationcraft:midnight Jun 2, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants