chore: replace strip-ansi with node native stripVTControlCharacters#159
chore: replace strip-ansi with node native stripVTControlCharacters#159baevm wants to merge 1 commit into
strip-ansi with node native stripVTControlCharacters#159Conversation
…rs` from `node:util`
|
Thanks for the PR. Quoting Sindre's README:
That's why we're using the package instead of the node builtin. It does need an update to the latest version, but I'm old school and trust Sindre to make solid updates faster than the Node team can. If you'd like to pivot this PR to updating that dep, that's cool and I'd merge that. Otherwise I thank you again for the contribution and you're welcome to close this one. |
Makes sense. My thinking was mostly that in this repo There’s also a small supply-chain angle here: even if strip-ansi itself is solid, it’s still another npm package to trust, and it was one of the packages compromised year ago: https://www.aikido.dev/blog/npm-debug-and-chalk-packages-compromised. |
|
Thanks for the follow-up. I'm good keeping the dep. |
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
Hi! This PR replaces
strip-ansidependency with nodejs nativestripVTControlCharactersfromnode:utilavailable since node 16.11.0