Rollup of 5 pull requests by JonathanBrouwer · Pull Request #157077 · rust-lang/rust

JonathanBrouwer · 2026-05-28T17:49:15Z

Successful merges:

Add bootstrap step for stdarch-verify #153957 (Add bootstrap step for stdarch-verify)
lib: specialize Clone of array IntoIter #156634 (lib: specialize Clone of array IntoIter)
Couple of changes to help with moving LTO to the link phase #157050 (Couple of changes to help with moving LTO to the link phase)
Add splitting caveats to {read,write}_volatile #156931 (Add splitting caveats to {read,write}_volatile)
Fix cfg typo in rustdoc book #157071 (Fix cfg typo in rustdoc book)

This seems like it was an oversight. It will be necessary in a future PR to serialize MaybeLtoModules as necessary to move LTO to the link phase.

…pendently

This would be useful for codegen backends that don't support LTO, yet do want to implement WriteBackendMethods.

@Kobzol

Add bootstrap step for stdarch-verify This PR hooks `library/stdarch/crates/stdarch-verify` crate into the bootstrap test runner as a step, so that we can run the stdarch-verify suite via x.py test. Changes : -> Added StdarchVerify in `src/bootstrap/src/core/build_steps/test.rs` -> Added `test::StdarchVerify` in `src/bootstrap/src/core/builder/mod.rs` Tests: -> Running `./x.py test library/stdarch/crates/stdarch-verify` builds compiler and std successfully. -> All three integration tests Passes: tests/arm.rs tests/mips.rs tests/x86-intel.rs -> Doc tests for `stdarch_verify` also Passes. r? @Kobzol

…clone, r=joboet lib: specialize Clone of array IntoIter This PR adds the `TrivialClone` specialization to the `PolymorphicIter` type, which `array::IntoIter` uses. I also added another coretest for the default case (already existing test catches the specialized one). There are no unwinding concerns since `TrivialClone` means cloning = copying and we never call `Clone::clone`. `array:IntoIter` is being used on a lot of places in both `core` and in user code, and `array::IntoIter` (nor does its users) override `Clone` often and just delegate to the inner type `PolymorphicIter` which does not yet do the `TrivialClone` specialization and is burdened by the iterator and unwind safety shenanigans for all types, so this PR should address some of that. This should in turn slightly reduce both stack usage and remove unwinding prologue/epilogue etc. from such functions and improve our `-Cno-prepopulate-passes` codegen too. perf: https://godbolt.org/z/eTPjj3hP3

Couple of changes to help with moving LTO to the link phase Part of rust-lang/compiler-team#908

…RalfJung Add splitting caveats to `{read,write}_volatile` It sounds like we don't actually have guarantees right now ([#t-opsem > Defining volatile splitting @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/136281-t-opsem/topic/Defining.20volatile.20splitting/near/597476292)) so let's document that. I think this doesn't need an FCP since it's not actually guaranteeing anything.

@yotamofek

…r=yotamofek Fix `cfg` typo in rustdoc book Fixes typo spotted by @yotamofek [here](rust-lang#157039 (comment)). r? @yotamofek

JonathanBrouwer · 2026-05-28T17:49:25Z

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-2

rust-bors · 2026-05-28T17:49:28Z

📌 Commit af4670c has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 5 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2

…uwer Rollup of 5 pull requests Successful merges: - #153957 (Add bootstrap step for stdarch-verify) - #156634 (lib: specialize Clone of array IntoIter) - #157050 (Couple of changes to help with moving LTO to the link phase) - #156931 (Add splitting caveats to `{read,write}_volatile`) - #157071 (Fix `cfg` typo in rustdoc book)

rust-bors · 2026-05-28T20:49:43Z

☀️ Try build successful (CI)
Build commit: 40a38d1 (40a38d163109be4a865a83736a176726c750b280, parent: 8c1d72083bb2b7b9df8cbbf06a57d240a007bd85)

rust-log-analyzer · 2026-05-28T21:32:57Z

The job x86_64-gnu-distcheck failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

 INFO Book building has started
 INFO Running the html backend
 INFO HTML book written to `/tmp/distcheck/distcheck-rustc-src/build/x86_64-unknown-linux-gnu/doc/rustc`
Doc path: /tmp/distcheck/distcheck-rustc-src/build/x86_64-unknown-linux-gnu/doc/rustc/index.html
##[group]Testing stage1 stdarch-verify (x86_64-unknown-linux-gnu)
error: no matching package named `syscalls` found
location searched: directory source `/tmp/distcheck/distcheck-rustc-src/vendor` (which is replacing registry `crates-io`)
required by package `core_arch v0.1.5 (/tmp/distcheck/distcheck-rustc-src/library/stdarch/crates/core_arch)`
note: offline mode (via `--frozen`) can sometimes cause surprising resolution failures
help: if this error is too confusing you may wish to retry without `--frozen`
Build completed unsuccessfully in 1:29:54
make: *** [Makefile:49: check] Error 1
Command `make check [workdir=/tmp/distcheck/distcheck-rustc-src]` failed with exit code 2
Created at: src/bootstrap/src/core/build_steps/test.rs:3549:5
Executed at: src/bootstrap/src/core/build_steps/test.rs:3555:10

--- BACKTRACE vvv
   0: <bootstrap::utils::exec::DeferredCommand>::finish_process
             at /checkout/src/bootstrap/src/utils/exec.rs:939:17
   1: <bootstrap::utils::exec::DeferredCommand>::wait_for_output::<&bootstrap::utils::exec::ExecutionContext>
             at /checkout/src/bootstrap/src/utils/exec.rs:831:21
   2: <bootstrap::utils::exec::ExecutionContext>::run
             at /checkout/src/bootstrap/src/utils/exec.rs:741:45
   3: <bootstrap::utils::exec::BootstrapCommand>::run::<&bootstrap::core::builder::Builder>
             at /checkout/src/bootstrap/src/utils/exec.rs:339:27
   4: bootstrap::core::build_steps::test::distcheck_plain_source_tarball
             at /checkout/src/bootstrap/src/core/build_steps/test.rs:3555:10
   5: <bootstrap::core::build_steps::test::Distcheck as bootstrap::core::builder::Step>::run
             at /checkout/src/bootstrap/src/core/build_steps/test.rs:3518:9
   6: <bootstrap::core::builder::Builder>::ensure::<bootstrap::core::build_steps::test::Distcheck>
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1596:36
   7: <bootstrap::core::build_steps::test::Distcheck as bootstrap::core::builder::Step>::make_run
             at /checkout/src/bootstrap/src/core/build_steps/test.rs:3501:21
   8: <bootstrap::core::builder::StepDescription>::maybe_run
             at /checkout/src/bootstrap/src/core/builder/mod.rs:476:13
   9: bootstrap::core::builder::cli_paths::match_paths_to_steps_and_run
             at /checkout/src/bootstrap/src/core/builder/cli_paths.rs:232:18
  10: <bootstrap::core::builder::Builder>::run_step_descriptions
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1139:9
  11: <bootstrap::core::builder::Builder>::execute_cli
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1118:14
  12: <bootstrap::Build>::build
             at /checkout/src/bootstrap/src/lib.rs:803:25
  13: bootstrap::main
             at /checkout/src/bootstrap/src/bin/main.rs:130:11
  14: <fn() as core::ops::function::FnOnce<()>>::call_once
             at /rustc/ef0fb8a2563200e322fa4419f09f65a63742038c/library/core/src/ops/function.rs:250:5
  15: std::sys::backtrace::__rust_begin_short_backtrace::<fn(), ()>
             at /rustc/ef0fb8a2563200e322fa4419f09f65a63742038c/library/std/src/sys/backtrace.rs:166:18
  16: std::rt::lang_start::<()>::{closure#0}
             at /rustc/ef0fb8a2563200e322fa4419f09f65a63742038c/library/std/src/rt.rs:206:18
  17: <&dyn core::ops::function::Fn<(), Output = i32> + core::marker::Sync + core::panic::unwind_safe::RefUnwindSafe as core::ops::function::FnOnce<()>>::call_once
             at /rustc/ef0fb8a2563200e322fa4419f09f65a63742038c/library/core/src/ops/function.rs:287:21
  18: std::panicking::catch_unwind::do_call::<&dyn core::ops::function::Fn<(), Output = i32> + core::marker::Sync + core::panic::unwind_safe::RefUnwindSafe, i32>
             at /rustc/ef0fb8a2563200e322fa4419f09f65a63742038c/library/std/src/panicking.rs:581:40
  19: std::panicking::catch_unwind::<i32, &dyn core::ops::function::Fn<(), Output = i32> + core::marker::Sync + core::panic::unwind_safe::RefUnwindSafe>
             at /rustc/ef0fb8a2563200e322fa4419f09f65a63742038c/library/std/src/panicking.rs:544:19
  20: std::panic::catch_unwind::<&dyn core::ops::function::Fn<(), Output = i32> + core::marker::Sync + core::panic::unwind_safe::RefUnwindSafe, i32>
             at /rustc/ef0fb8a2563200e322fa4419f09f65a63742038c/library/std/src/panic.rs:359:14
  21: std::rt::lang_start_internal::{closure#0}
             at /rustc/ef0fb8a2563200e322fa4419f09f65a63742038c/library/std/src/rt.rs:175:24
  22: std::panicking::catch_unwind::do_call::<std::rt::lang_start_internal::{closure#0}, isize>
             at /rustc/ef0fb8a2563200e322fa4419f09f65a63742038c/library/std/src/panicking.rs:581:40
---
  29: __libc_start_main
  30: _start


Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `test distcheck`
Build completed unsuccessfully in 1:37:32
  local time: Thu May 28 21:32:18 UTC 2026
  network time: Thu, 28 May 2026 21:32:18 GMT
##[error]Process completed with exit code 1.

rust-bors · 2026-05-28T21:33:36Z

💔 Test for cbfd997 failed: CI. Failed job:

auto - x86_64-gnu-distcheck (web logs, enhanced plaintext logs)

rust-bors · 2026-05-29T07:04:49Z

This pull request was unapproved due to being closed.

Paladynee and others added 13 commits May 16, 2026 10:31

specialize Clone of array IntoIter

5cec957

Add splitting caveats to {read,write}_volatile

1fbba58

Implement SpanEncoder for MemEncoder

1fae0e3

This seems like it was an oversight. It will be necessary in a future PR to serialize MaybeLtoModules as necessary to move LTO to the link phase.

Support implementing ExtraBackendMethods and WriteBackendMethods inde…

9f8820b

…pendently

Inline a small function

3ef6839

Implement ModuleBufferMethods for Infallible

32b6107

This would be useful for codegen backends that don't support LTO, yet do want to implement WriteBackendMethods.

Add bootstrap step for stdarch-verify

782ab6a

Fix cfg typo in rustdoc book

2771eb4

Rollup merge of rust-lang#157050 - bjorn3:lto_refactors19, r=lqd

fecb947

Couple of changes to help with moving LTO to the link phase Part of rust-lang/compiler-team#908

Rollup merge of rust-lang#157071 - GuillaumeGomez:rustdoc-book-typo, …

af4670c

…r=yotamofek Fix `cfg` typo in rustdoc book Fixes typo spotted by @yotamofek [here](rust-lang#157039 (comment)). r? @yotamofek

rust-bors Bot added the rollup A PR which is a rollup label May 28, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 28, 2026

JonathanBrouwer closed this May 29, 2026

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 29, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 29, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests#157077

Rollup of 5 pull requests#157077
JonathanBrouwer wants to merge 13 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-pWvdmJO

JonathanBrouwer commented May 28, 2026

Uh oh!

JonathanBrouwer commented May 28, 2026

Uh oh!

rust-bors Bot commented May 28, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented May 28, 2026

Uh oh!

rust-log-analyzer commented May 28, 2026

Uh oh!

rust-bors Bot commented May 28, 2026

Uh oh!

rust-bors Bot commented May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

JonathanBrouwer commented May 28, 2026

Uh oh!

JonathanBrouwer commented May 28, 2026

Uh oh!

rust-bors Bot commented May 28, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented May 28, 2026

Uh oh!

rust-log-analyzer commented May 28, 2026

Uh oh!

rust-bors Bot commented May 28, 2026

Uh oh!

rust-bors Bot commented May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants