rustdoc: correctly propagate cfgs for glob reexports#157039
Open
lcian wants to merge 1 commit into
Open
Conversation
67eb276 to
e1944da
Compare
e1944da to
028afca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some cases of rustdoc not surfacing the correct required feature combination when using
#[cfg(feature = ...)]in combination with glob reexports.See the example cases included as tests.
Here's the generated HTML for those test cases before this change:

and after:

My understanding is that this was basically an off-by-one type of oversight.
We need to update
is_inlinebefore callingget_all_import_attributesto immediately reflect that the outermost import we're processing shall indeed be considered as inline, as it's a glob.Otherwise, we will end up calling
add_without_unwanted_attributeswithis_inline == falseon the "intermediate" re-exports, which will skip propagating theircfgs.I believe this fixes #96166, even though the description there is not super clear on the exact test case they used (there's a snippet but the author says their code is actually different).
Refs #43781
@rustbot label +F-doc_cfg
@rustbot r? @GuillaumeGomez