ci: remove pull_request_target trigger from release-drafter#31
Open
ryantm wants to merge 1 commit into
Open
Conversation
Removes the pull_request_target trigger from the release-drafter workflow to eliminate exposure to the supply-chain-attack pattern abused in the TanStack NPM compromise. See: https://tanstack.com/blog/npm-supply-chain-compromise-postmortem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The recent TanStack NPM supply-chain compromise was facilitated by a
pull_request_targetworkflow. Per Replit security policy, we're removingpull_request_targettriggers from all Replit-owned public repos as a precaution, even where the current use looks safe, to eliminate exposure to that attack pattern.Discussion: Slack thread.
What changed
Removed the
pull_request_targettrigger block from.github/workflows/release-drafter.yml. The workflow still runs on:workflow_dispatch(manual)pushtomain— release notes continue to be drafted on mergepull_requestfrom branches in the same repo — autolabeler still runs hereTradeoff: the autolabeler will no longer run on PRs opened from forks. That's an acceptable loss given the security benefit, and the rest of the release-drafter flow (drafting release notes on push to
main) is unaffected.Test plan
pull_request_target:block; no other lines change.yq/manual YAML inspection confirms the remainingon:triggers (workflow_dispatch,push,pull_request) still parse correctly.main(release notes still draft) and the next intra-repo PR (autolabeler still fires).Rollout
Workflow-only change with no runtime impact on the published package.
Revertibility
Safe to revert. This is a workflow-only change; reverting restores the prior trigger configuration with no data or state implications.
~ written by Zerg 👾 (hungry-medic-9d57)