fix(lint): properly resolve vue/multi-word-component-names violations#71
Merged
Conversation
The rule was disabled in 6dfd359 to silence an ESLint error on Settings.vue instead of fixing the underlying single-word component names.
Adds defineOptions({ name: 'SettingsView' }) to satisfy the
vue/multi-word-component-names rule without renaming the file.
Same rule applies: Dashboard is a single-word component name.
dev carries Sidebar, Home and Sources (not present when this PR branched), which the now-enabled vue/multi-word-component-names rule flags. Add defineOptions names so lint passes after the merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #48
Commit
6dfd359resolved the ESLint error by disablingvue/multi-word-component-namesglobally ineslint.config.jsrather than fixing the two offending components. This PR reverses that shortcut and applies the correct fix.eslint.config.js—vue/multi-word-component-namesre-enabled ('error').vue/block-langremains off (intentional: many components still use JS<script setup>without alangattribute).src/views/Settings.vue—defineOptions({ name: 'SettingsView' })added. No file rename needed;defineOptionsis the idiomatic way to set an explicit multi-word name in<script setup>.src/views/Dashboard.vue—defineOptions({ name: 'DashboardView' })added. Same violation, same fix.No router changes required — imports reference file paths, not component names.
Test plan
npm run lintpasses with zerovue/multi-word-component-nameserrors/(Dashboard) and/settingscorrectly