Fix system collection view fallback & Windows extension build#236
Open
Manas-5461X wants to merge 1 commit into
Open
Fix system collection view fallback & Windows extension build#236Manas-5461X wants to merge 1 commit into
Manas-5461X wants to merge 1 commit into
Conversation
|
@Manas-5461X is attempting to deploy a commit to the Raindrop Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where system collections (like "All Bookmarks") would revert to the default list view and ignore global user settings after a data refresh.
Changes:
System Collection View Fix (
items.js): Updated thedefCollsmapping to properly respect locally overridden views (item.view) and fall back to the globaluser.config.default_collection_view. Previously, the view was being dropped duringloadCollections, causing it to fall back to the hardcodedlistdefault during normalization.Windows Build Fix (
build/extension.js): Tweaked themanifest/index.jsregex to support both Windows (\) and Unix (/) directory separators. This prevents Webpack from mistakenly trying to bundle the manifest script for the browser on Windows (which was causingfsandpathnot found crashes).Tested On