Skip to content

Fix false positive for NamedTuple subtype of TupleType #21529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JiwaniZakir wants to merge 1 commit into from
+4 −0
Closed

Fix false positive for NamedTuple subtype of TupleType #21529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mypy/subtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,10 @@ def visit_instance(self, left: Instance) -> bool:
or mapped.type.has_type_var_tuple_type
):
return True
# A NamedTuple Instance is a subtype of its own TupleType
# representation (they are two views of the same type).
if mapped.type.is_named_tuple and mapped.type is right.partial_fallback.type:
return True
return False
if isinstance(right, TypeVarTupleType):
# tuple[Any, ...] is like Any in the world of tuples (see special case above).
Expand Down
Loading