bpo-36017: Improve test_grp.test_errors for (big) LDAP directories#19033
Closed
MatzeB wants to merge 2 commits into
Closed
bpo-36017: Improve test_grp.test_errors for (big) LDAP directories#19033MatzeB wants to merge 2 commits into
MatzeB wants to merge 2 commits into
Conversation
There is no guarantee that the group database returned on unix system is complete. It is typically cut short when LDAP directories are configured for bigger network setups. This makes it tricky to find a nonexistent group id by looking at the group database. This changes the test to pick a nonexistent gid within gid 1-99 which are typically static assigned and not managed by network directory systems. Also pick a group name that is extremely likely to not exist instead of modifying the name of the first group in the database. skip news
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Would not be simpler to generate a random name? If by accident it matches existing name, we can repeat in loop.
|
This PR is stale because it has been open for 30 days with no activity. |
Closed
Member
|
#150380 uses random names and ids in test_pwd and test_grp and adds more tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no guarantee that the group database returned on a unix system is
complete. It is typically cut short when LDAP directories are configured
for bigger network setups. This makes it tricky to find a nonexistent
group id by looking at the group database.
This changes the test to pick a nonexistent gid within gid 1-99 which
are typically static assigned and not managed by network directory
systems.
Also pick a group name that is extremely likely to not exist instead of
modifying the name of the first group in the database.
https://bugs.python.org/issue36017