gh-150372: add missing null check on completer_word_break_characters in readline.c#150251
Open
KowalskiThomas wants to merge 3 commits into
Open
gh-150372: add missing null check on completer_word_break_characters in readline.c#150251KowalskiThomas wants to merge 3 commits into
completer_word_break_characters in readline.c#150251KowalskiThomas wants to merge 3 commits into
Conversation
KowalskiThomas
changed the title
strdup
Member
|
Please create both an issue and a NEWS entry and update the PR title. It does not indicate what the change is about and is a poor commit message. |
KowalskiThomas
changed the title
strdupstrdup
KowalskiThomas
changed the title
strdupcompleter_word_break_characters
KowalskiThomas
changed the title
completer_word_break_characterscompleter_word_break_characters in readline.c
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR?
This adds a missing null pointer check on the result of an
strdupcall used to populatecompleter_word_break_characters. This matches what the remainder of the files does (so I assume this wasn't on purpose / being optimistic aboutstrdup).readlineis missing a null pointer check onstrdupreturn value #150372