gh-149738: Fix segmentation fault bug in sqllite3#149754
Conversation
picnixz
left a comment
There was a problem hiding this comment.
We need tests and check what happens on the created connection after deletion (check that there is still a row factory on the newly created cursor)
|
Thanks for your comment and review, @picnixz! P.S. The Read the Docs build is failing, but the logs indicate it’s due to an external issue unrelated to my changes. |
vstinner
left a comment
There was a problem hiding this comment.
I would prefer using connection_getset instead of connection_members for row_factory and text_factory to raise an exception if the developer tries to delete the attribute (set it to NULL). Add get/set on these attributes.
|
Hi @vstinner! Thank you for your kind review. Sorry for the delay, GitHub access has been unreliable here recently. |
Fixes #149738.