Change bless to clean up absolute paths#22067
Open
NattyNarwhal wants to merge 1 commit into
Open
Conversation
User-specific absolute paths should be avoided in tests, since they aren't portable. Change bless to detect common places where this occurs and make it use %s in EXPECTF if so. This was originally developed as part of phpGH-12276. While the approved RFC doesn't enable function parameters to be printed for tests, the functionality is generally useful.
TimWolla
reviewed
May 17, 2026
| $out = preg_replace('/string\(\d+\) "([^"]*%d)/', 'string(%d) "$1', $out); | ||
| // Inside of strings, replace absolute paths that have been truncated with | ||
| // any string. These tend to contain homedirs with usernames, not good. | ||
| $out = preg_replace("/'\\/.*\.\\.\\.'/", "'%s'", $out); |
Member
There was a problem hiding this comment.
I think this regex should be aligned with the one for the error messages: (\/|[A-Z]:\\\\)\S+ (i.e. support for Windows and no whitespace).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-specific absolute paths should be avoided in tests, since they aren't portable. Change bless to detect common places where this occurs and make it use %s in EXPECTF if so.
This was originally developed as part of GH-12276. While the approved RFC doesn't enable function parameters to be printed for tests, the functionality is generally useful.