Skip to content

uloop: use volatile sig_atomic_t for uloop_cancelled and uloop_status #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hauke wants to merge 1 commit into
base: master
Choose a base branch
from
Open

uloop: use volatile sig_atomic_t for uloop_cancelled and uloop_status #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions uloop.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ static struct list_head processes = LIST_HEAD_INIT(processes);
static struct list_head signals = LIST_HEAD_INIT(signals);

static int poll_fd = -1;
bool uloop_cancelled = false;
volatile sig_atomic_t uloop_cancelled = 0;
bool uloop_handle_sigchld = true;
static int uloop_status = 0;
static volatile sig_atomic_t uloop_status = 0;
static volatile sig_atomic_t do_sigchld = 0;

static struct uloop_fd_event cur_fds[ULOOP_MAX_EVENTS];
Expand Down Expand Up @@ -670,7 +670,7 @@ int uloop_run_timeout(int timeout)
uloop_run_depth++;

uloop_status = 0;
uloop_cancelled = false;
uloop_cancelled = 0;
do {
uloop_process_timeouts();

Expand Down
4 changes: 2 additions & 2 deletions uloop.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ struct uloop_signal
int signo;
};

extern bool uloop_cancelled;
extern volatile sig_atomic_t uloop_cancelled;
extern bool uloop_handle_sigchld;
extern uloop_fd_handler uloop_fd_set_cb;

Expand Down Expand Up @@ -140,7 +140,7 @@ bool uloop_cancelling(void);

static inline void uloop_end(void)
{
uloop_cancelled = true;
uloop_cancelled = 1;
}

int uloop_init(void);
Expand Down
Loading