OPRUN-4608: UPSTREAM: <carry>: Delete openshift/registry.Dockerfile#729
OPRUN-4608: UPSTREAM: <carry>: Delete openshift/registry.Dockerfile#729joelanford wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
|
@joelanford: This pull request references OPRUN-4608 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Needs rebase, and I'd like to get the sync PR in first... |
e6fe064 to
36fa1a5
Compare
|
/hold until #726 merges |
The e2e-test-registry image is no longer built by CI after openshift/release#78581 removed it from the CI config. The dynamic per-scenario catalog system replaced the pre-built registry image, making this Dockerfile dead code.
36fa1a5 to
89ed0b7
Compare
|
#726 merged |
|
/hold cancel |
|
@joelanford: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
openshift/registry.Dockerfile— this Dockerfile built thee2e-test-registryimage which is no longer used by CI after Remove e2e-test-registry image build from operator-controller main config release#78581 removed it from the CI config.Context
The dynamic per-scenario catalog system replaced the pre-built registry image. The CI config removal landed first (openshift/release#78581), so this Dockerfile is now dead code.
Test plan
openshift/registry.DockerfileJira: OPRUN-4608
Summary by CodeRabbit