Skip to content

OPRUN-4608: UPSTREAM: <carry>: Delete openshift/registry.Dockerfile#729

Open
joelanford wants to merge 1 commit into
openshift:mainfrom
joelanford:OPRUN-4608-remove-registry-dockerfile
Open

OPRUN-4608: UPSTREAM: <carry>: Delete openshift/registry.Dockerfile#729
joelanford wants to merge 1 commit into
openshift:mainfrom
joelanford:OPRUN-4608-remove-registry-dockerfile

Conversation

@joelanford
Copy link
Copy Markdown
Member

@joelanford joelanford commented May 19, 2026

Summary

Context

The dynamic per-scenario catalog system replaced the pre-built registry image. The CI config removal landed first (openshift/release#78581), so this Dockerfile is now dead code.

Test plan

  • CI passes without the file
  • No other files reference openshift/registry.Dockerfile

Jira: OPRUN-4608

Summary by CodeRabbit

  • Chores
    • Removed legacy build configuration file.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 19, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 19, 2026

@joelanford: This pull request references OPRUN-4608 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Context

The dynamic per-scenario catalog system replaced the pre-built registry image. The CI config removal landed first (openshift/release#78581), so this Dockerfile is now dead code.

Test plan

  • CI passes without the file
  • No other files reference openshift/registry.Dockerfile

Jira: OPRUN-4608

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Walkthrough

The openshift/registry.Dockerfile file has been completely removed from the repository. This file previously contained a multi-stage Docker build that compiled a push utility binary and prepared container image artifacts for OpenShift deployment.

Changes

Cohort / File(s) Summary
Dockerfile Deletion
openshift/registry.Dockerfile
Complete removal of the OpenShift registry Dockerfile, including the multi-stage build configuration that compiled testdata/push/push.go and prepared container artifacts.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Custom check applies only to Ginkgo tests. This codebase uses standard Go testing, not Ginkgo. PR only removes a Dockerfile, no test names were modified.
Test Structure And Quality ✅ Passed This PR removes openshift/registry.Dockerfile, a configuration file, not Ginkgo test code. The custom check targets Ginkgo test quality and is not applicable to Dockerfile deletions.
Microshift Test Compatibility ✅ Passed New e2e tests use only standard Kubernetes APIs (Deployments, Pods, NetworkPolicies, RBAC) with no MicroShift-incompatible APIs detected.
Single Node Openshift (Sno) Test Compatibility ✅ Passed SNO compatibility check applies only to new Ginkgo e2e tests. This PR removes a Dockerfile with no test code changes, so the check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR deletes a test Dockerfile, not deployment manifests or operator code. No Kubernetes scheduling constraints introduced or modified.
Ote Binary Stdout Contract ✅ Passed PR only removes openshift/registry.Dockerfile, a Dockerfile (Docker config), not Go code. Custom check applies to stdout in OTE binaries' Go code, which is not affected by this change.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR removes openshift/registry.Dockerfile (a container build file). The custom check applies only when new Ginkgo e2e tests are added. No test code is present.
Title check ✅ Passed The title accurately describes the main change: deletion of openshift/registry.Dockerfile, which is the primary modification in this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2026
@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented May 19, 2026

Needs rebase, and I'd like to get the sync PR in first...

@joelanford joelanford changed the title OPRUN-4608: Delete openshift/registry.Dockerfile OPRUN-4608: UPSTREAM: <carry>: Delete openshift/registry.Dockerfile May 19, 2026
@joelanford joelanford force-pushed the OPRUN-4608-remove-registry-dockerfile branch from e6fe064 to 36fa1a5 Compare May 19, 2026 15:03
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2026
@joelanford joelanford marked this pull request as ready for review May 19, 2026 17:22
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 19, 2026
@joelanford
Copy link
Copy Markdown
Member Author

/hold

until #726 merges

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2026
@openshift-ci openshift-ci Bot requested review from dtfranz and perdasilva May 19, 2026 17:23
The e2e-test-registry image is no longer built by CI after
openshift/release#78581 removed it from the CI config. The dynamic
per-scenario catalog system replaced the pre-built registry image,
making this Dockerfile dead code.
@joelanford joelanford force-pushed the OPRUN-4608-remove-registry-dockerfile branch from 36fa1a5 to 89ed0b7 Compare May 19, 2026 17:25
@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented May 19, 2026

#726 merged

@joelanford
Copy link
Copy Markdown
Member Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

@joelanford: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants