[release-4.21] OCPBUGS-86119: Add unit and e2e test coverage for cert rotation redeployment

[jhadvig]

Summary

• Cherry-pick of 0a408ad adding unit and e2e test coverage for cert rotation redeployment
• Follow-up to OCPBUGS-82037 fix (PR [release-4.21] OCPBUGS-82037: Redeploy console pods upon cert rotation #1139) which was merged without test coverage
• Adds TestServingCertAnnotationChangesOnRotation, TestServingCertAnnotationInResourceAnnotations (unit) and TestCertRotationTriggersRollout (e2e)

Test plan

• Unit tests pass: go test ./pkg/console/subresource/deployment/ -run TestServingCert
• E2E test passes on a cluster: TestCertRotationTriggersRollout

Jira: https://issues.redhat.com/browse/OCPBUGS-86119

[openshift-ci-robot]

@jhadvig: This pull request references Jira Issue OCPBUGS-86119, which is invalid:

• expected the bug to target the "4.21.z" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected dependent Jira Issue OCPBUGS-86117 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead
• expected dependent Jira Issue OCPBUGS-86117 to target a version in 4.22.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Cherry-pick of 0a408ad adding unit and e2e test coverage for cert rotation redeployment
• Follow-up to OCPBUGS-82037 fix (PR [release-4.21] OCPBUGS-82037: Redeploy console pods upon cert rotation #1139) which was merged without test coverage
• Adds TestServingCertAnnotationChangesOnRotation, TestServingCertAnnotationInResourceAnnotations (unit) and TestCertRotationTriggersRollout (e2e)

Test plan

• Unit tests pass: go test ./pkg/console/subresource/deployment/ -run TestServingCert
• E2E test passes on a cluster: TestCertRotationTriggersRollout

Jira: https://issues.redhat.com/browse/OCPBUGS-86119

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3c623161-f533-428e-9cce-2d1d3baa2a58

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jhadvig]

/override ci/prow/e2e-aws-console

[jhadvig]

/verified by CI
/label backport-risk-assessed

[openshift-ci-robot]

@jhadvig: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/e2e-aws-console

Details

In response to this:

/override ci/prow/e2e-aws-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@jhadvig: Jira Issue Verification Checks: Jira Issue OCPBUGS-86119
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-86119 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary

• Cherry-pick of 0a408ad adding unit and e2e test coverage for cert rotation redeployment
• Follow-up to OCPBUGS-82037 fix (PR [release-4.21] OCPBUGS-82037: Redeploy console pods upon cert rotation #1139) which was merged without test coverage
• Adds TestServingCertAnnotationChangesOnRotation, TestServingCertAnnotationInResourceAnnotations (unit) and TestCertRotationTriggersRollout (e2e)

Test plan

• Unit tests pass: go test ./pkg/console/subresource/deployment/ -run TestServingCert
• E2E test passes on a cluster: TestCertRotationTriggersRollout

Jira: https://issues.redhat.com/browse/OCPBUGS-86119

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@jhadvig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-console	20a2361	link	unknown	/test e2e-aws-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-merge-robot]

Fix included in release 4.21.0-0.nightly-2026-05-26-155514