fix(deps): update module k8s.io/apimachinery to v0.36.1#972
fix(deps): update module k8s.io/apimachinery to v0.36.1#972red-hat-konflux[bot] wants to merge 1 commit into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughGo toolchain bumped from 1.24.6 to 1.25.0. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
e31b633 to
3a60df5
Compare
ℹ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
3a60df5 to
e31b633
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@go.mod`:
- Line 3: The go.mod change to "go 1.25.0" introduces several platform and
toolchain changes you must verify: confirm container and CI runtimes tolerate
dynamic GOMAXPROCS (or set GODEBUG=containermaxprocs=0,updatemaxprocs=0), run
ASAN-enabled builds/tests and add ASAN_OPTIONS=detect_leaks=0 if needed, audit
code paths for unsafe ordering that relied on pre-1.25 nil-check behavior
(search for functions/locations that perform nil checks then use values),
validate DWARF v5 compatibility with your debuggers or opt-out with
GOEXPERIMENT=nodwarf5, ensure TLS peers accept SHA-1 or set GODEBUG=tlssha1=1
for legacy compatibility, verify macOS build environments meet Monterey+
requirement, and review the bumped dependency k8s.io/apimachinery v0.35.0 for
API changes—make configuration/environment updates and test runs accordingly
before merging.
e31b633 to
505bd41
Compare
505bd41 to
02276ab
Compare
02276ab to
8aae8af
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 3: go.mod requires Go 1.25.0 but CI and Docker use older versions; update
the GitHub workflow files and Dockerfile to match: change go-version entries in
.github/workflows/check-pull-request.yaml (both matrix entries currently
1.22/1.23) and .github/workflows/publish-release.yaml (currently 1.23) to
1.25.0, and update docker/Dockerfile to use a base image that provides Go 1.25.0
(replace ubi9/go-toolset:latest with a pinned image/tag that includes Go 1.25.0)
so the build environment matches go.mod.
| module github.com/openshift-online/ocm-cli | ||
|
|
||
| go 1.24.6 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Find Go version references in CI, build, and config files
echo "=== Searching for Go version references ==="
# Common locations for Go version pins
rg -i 'go.?version|golang|GO_VERSION' --type yaml --type yml --type json --type dockerfile --type sh --type toml -n | head -50
echo ""
echo "=== Checking CI workflows directory ==="
fd -t f '\.(yml|yaml|json)$' '.github/workflows' 2>/dev/null | head -20
echo ""
echo "=== Checking for Dockerfile ==="
fd -t f 'Dockerfile' | head -10
echo ""
echo "=== Checking for build scripts ==="
fd -t f '\.(sh|mk|Makefile)$' | grep -E '(build|Make|script)' | head -20
echo ""
echo "=== Checking for .go-version or similar files ==="
fd -t f '\.go-version|go-version\.txt|\.tool-versions'
echo ""
echo "=== Checking go.mod for Go version directive ==="
head -5 go.modRepository: openshift-online/ocm-cli
Length of output: 609
🏁 Script executed:
#!/bin/bash
echo "=== Checking GitHub Actions workflows for Go version ==="
cat .github/workflows/check-pull-request.yaml | grep -A 5 -B 5 'go-version\|golang\|setup-go' -i
echo ""
echo "=== Checking Dockerfile for Go base image ==="
head -20 docker/Dockerfile
echo ""
echo "=== Checking build scripts for Go version ==="
grep -n 'go\|golang\|1\.2[0-9]' hack/build_image.sh | head -20
echo ""
echo "=== Checking all workflow files ==="
cat .github/workflows/publish-release.yaml | grep -A 5 -B 5 'go-version\|golang\|setup-go' -iRepository: openshift-online/ocm-cli
Length of output: 2531
Fix Go version mismatch: CI workflows use Go 1.22 and 1.23, but go.mod requires 1.25.0.
Update CI workflows and Dockerfile to match the Go 1.25.0 requirement in go.mod:
.github/workflows/check-pull-request.yaml: Changego-versionfrom 1.22 and 1.23 to 1.25.0.github/workflows/publish-release.yaml: Changego-versionfrom 1.23 to 1.25.0docker/Dockerfile: Replaceubi9/go-toolset:latestwith a pinned version that includes Go 1.25.0
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 3, go.mod requires Go 1.25.0 but CI and Docker use older
versions; update the GitHub workflow files and Dockerfile to match: change
go-version entries in .github/workflows/check-pull-request.yaml (both matrix
entries currently 1.22/1.23) and .github/workflows/publish-release.yaml
(currently 1.23) to 1.25.0, and update docker/Dockerfile to use a base image
that provides Go 1.25.0 (replace ubi9/go-toolset:latest with a pinned image/tag
that includes Go 1.25.0) so the build environment matches go.mod.
797126b to
f2c3576
Compare
f2c3576 to
1b4b639
Compare
1b4b639 to
7a20abd
Compare
7a20abd to
94b5fbd
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
94b5fbd to
0ba08a6
Compare
ℹ️ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
0ba08a6 to
7c0f264
Compare
7c0f264 to
ed9c279
Compare
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
|
@red-hat-konflux[bot]: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR contains the following updates:
v0.34.3→v0.36.1Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
kubernetes/apimachinery (k8s.io/apimachinery)
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.5Compare Source
v0.35.4Compare Source
v0.35.3Compare Source
v0.35.2Compare Source
v0.35.1Compare Source
v0.35.0Compare Source
v0.34.8Compare Source
v0.34.7Compare Source
v0.34.6Compare Source
v0.34.5Compare Source
v0.34.4Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.