feat(watcher): add on_callback_error hook to WatchedField and AsyncWatchedField#97
Merged
Conversation
…tchedField Previously, on_change callback exceptions were silently swallowed and only logged. Users had no way to opt into fail-loud behavior or custom error handling. Add on_callback_error: Callable[[Exception], None] | None = None to _WatchedFieldBase.__init__, WatchedField.__init__, and AsyncWatchedField.__init__. Thread the parameter through both ConfigWatcher.field() and AsyncConfigWatcher.field() so it's accessible at the call site. When set, the hook is called with the exception instead of logging. If the hook re-raises, the watcher loop terminates. Closes #61 Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on_changecallback raised — exceptions were silently logged and discarded.on_callback_error: Callable[[Exception], None] | None = Noneparameter toWatchedField,AsyncWatchedField, and their respectivefield()registration methods, giving callers full control over error handling.Test plan
test_on_callback_error_hook_is_called— verifies hook receives the exception instead of swallowing it (sync + async)test_on_callback_error_hook_via_field_method— verifies the parameter threads correctly throughConfigWatcher.field()/AsyncConfigWatcher.field()(sync + async)test_callback_exception_is_logged— confirms default behavior (log, no raise) is unchangedCloses #61