feat(constants): auto-source SUPPORTED_SERVER_VERSION from pyproject.toml#101
Merged
Conversation
…toml Move the version constraint to [tool.opendecree] in pyproject.toml as the single source of truth. build/gen-constants.py reads it and writes sdk/src/opendecree/_constants.py; make generate now runs gen-constants first. __init__.py imports SUPPORTED_SERVER_VERSION from _constants.py instead of hardcoding it. Also fix the build/ .gitignore rule — it was too broad, silently requiring force-add for Dockerfile.tools. Negation patterns now let tracked scripts (*.py, Dockerfile.tools) be added normally. Closes #64 Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__init__.py—[tool.opendecree].supported_server_versioninpyproject.tomlis now the single source of truth.build/gen-constants.pyscript reads the value at codegen time and writessdk/src/opendecree/_constants.py;make generateruns it automatically before proto generation.build/gitignore rule that silently requiredgit add -ffor tracked scripts.Test plan
make test— 240 passed, 97.49% coverage,_constants.pyat 100%make lint— all checks passedmake typecheck— no issues in 28 source filesSUPPORTED_SERVER_VERSIONvalue unchanged;_compat.pyimport path verifiedCloses #64