feat(web): merge Fleet into a server-filterable Dashboard (UI nav Phase 1)#61
Open
offendingcommit wants to merge 1 commit into
Open
feat(web): merge Fleet into a server-filterable Dashboard (UI nav Phase 1)#61offendingcommit wants to merge 1 commit into
offendingcommit wants to merge 1 commit into
Conversation
Implements Phase 1 of the UI navigation rework (docs/superpowers/specs/ 2026-06-02-ui-navigation-rework.md): the Dashboard now lists every workspace across every configured server as <workspace> (<server>), filterable by server, with cross-server aggregate cards (reusing computeFleetAggregates). Opening a workspace activates its server then drills into the existing detail route. Per-server fan-out lives in a ServerWorkspaceRows child (rules-of-hooks safe, mirrors FleetRow). Fleet removed from the sidebar nav; the /fleet route is left intact for now (full removal deferred to avoid churning fleet.test.tsx while #54 is open).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Phase 1 of the UI navigation rework spec
(
docs/superpowers/specs/2026-06-02-ui-navigation-rework.md, PR #55): merge thesingle-instance Dashboard and the multi-instance Fleet view into one
server-aware Dashboard.
labelled
<workspace> (<server>), with a server filter (default "All servers").reuse
computeFleetAggregates— the former Fleet metrics.existing
/workspaces/$workspaceIddetail route — no new routes needed.ServerWorkspaceRowschild component(one per server → rules-of-hooks safe; mirrors the proven
FleetRowpattern).Files
packages/web/src/components/dashboard/Dashboard.tsx— rewritten as the unified parent.packages/web/src/components/dashboard/ServerWorkspaceRows.tsx— new per-server child.packages/web/src/components/layout/Sidebar.tsx— drop Fleet fromTOP_NAV.packages/web/src/test/dashboard.test.tsx— new (renders the route, asserts the<server>labels + the server filter narrowing).Validation
make ci-webgreen (lint + typecheck + tests + build).dashboard.test.tsxrenders the real Dashboard through the router (mocked transport)and asserts: both servers' workspaces appear labelled
(Neo)/(Iris); the filterlists each server; selecting one narrows to it.
via
make dev-web(ormake up). The drill-down activate-then-navigate path is logic-tested but not exercised in a real browser here.
Deferred (intentional)
/fleetroute +FleetDashboard/FleetRowremoval is left for a follow-up:removing it churns
fleet.test.tsx, which PR feat(web): eliminate browser CORS via header-driven /api proxy #54 also edits — doing it here wouldcreate a needless merge conflict.
/fleetstays reachable by URL (just unlinked)until feat(web): eliminate browser CORS via header-driven /api proxy #54 lands, then a small cleanup PR removes the route + dead components.
ops/settings view) still need the brainstorming pass per the spec.
Independent of #54–#57 (touches none of their files).