TW-4937: surface API request ID in CLI error output#80
Merged
Conversation
Extract request_id from API error responses (body + header fallback) and display it on a dedicated line in formatted CLI errors, giving users an actionable reference for support and debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request_idfrom Nylas API error responses (JSON body with header fallback) and propagate throughAPIError→CLIError→FormatError[request_id: ...]from the error message inFormatErrorpath to avoid duplication while preserving it inError()for logging contextsRelated docs
Commands affected by improved error output:
Commands referenced in error suggestions:
Test plan
make cipassesNYLAS_API_KEY=bogus ./bin/nylas email list fake-grant-idshowsRequest ID:on its own line, not duplicated in the messagenylas email listwith no API key) show noRequest ID:lineWrapError,FormatErrorrendering, blank request ID omission, inline suffix stripping