Skip to content

remove unmaintained mastodon link from footer (#7873)#8902

Closed
CodingRule wants to merge 3 commits into
nodejs:mainfrom
CodingRule:main
Closed

remove unmaintained mastodon link from footer (#7873)#8902
CodingRule wants to merge 3 commits into
nodejs:mainfrom
CodingRule:main

Conversation

@CodingRule
Copy link
Copy Markdown
Contributor

This closes #7873.

Description

  • remove the retired Mastodon link from the website footer
  • remove the hidden rel="me" Mastodon reference from the root layout
  • add a regression test so the retired URL is not added back

Validation

  • pnpm format passes
  • pnpm test passes
  • pnpm build passes
  • node --test apps/site/util/__tests__/navigation.test.mjs passes
  • git diff --check passes
  • reviewers can confirm that the footer no longer shows the Mastodon icon/link and that the root layout no longer contains https://social.lfx.dev/@nodejs
  • pnpm build prints an existing Next.js warning about the deprecated middleware file convention, but the build completes successfully

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Elure <ioumih32@gmail.com>
Signed-off-by: Elure <ioumih32@gmail.com>
Signed-off-by: Elure <ioumih32@gmail.com>
Copilot AI review requested due to automatic review settings May 18, 2026 08:27
@CodingRule CodingRule requested a review from a team as a code owner May 18, 2026 08:27
@vercel
Copy link
Copy Markdown

vercel Bot commented May 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview May 18, 2026 8:28am

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 18, 2026

PR Summary

Low Risk
Low risk: removes a retired social link and a hidden rel="me" reference, plus adds a small regression test; no functional/business logic changes beyond footer navigation content.

Overview
Removes the retired Mastodon URL (https://social.lfx.dev/@nodejs) from the site by deleting the hidden rel="me" anchor in app/[locale]/layout.tsx and dropping the Mastodon entry from navigation.json social links.

Adds a Node test (util/__tests__/navigation.test.mjs) to prevent the retired Mastodon URL from being reintroduced in either the navigation config or the root layout.

Reviewed by Cursor Bugbot for commit 3f6cf28. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an unmaintained Mastodon profile reference from the site’s footer/navigation config and from the root layout, and adds a regression test to prevent reintroducing the retired URL.

Changes:

  • Removed the Mastodon entry from apps/site/navigation.json social links (footer icons/links).
  • Removed the hidden rel="me" Mastodon anchor from the root layout.
  • Added a unit test ensuring the retired URL is not present in navigation config or the root layout.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
apps/site/util/tests/navigation.test.mjs Adds regression assertions preventing the retired Mastodon URL from returning in navigation or layout.
apps/site/navigation.json Removes the Mastodon social link entry from socialLinks.
apps/site/app/[locale]/layout.tsx Removes the hidden rel="me" link pointing to the retired Mastodon profile.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avivkeller avivkeller closed this May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The mastodon listed on the Website is unmaintained

3 participants