build,win: fix VS2022 arm64 PGO build#63413
Open
StefanStojanovic wants to merge 1 commit into
Open
Conversation
Refs: nodejs#62761 Signed-off-by: StefanStojanovic <stefan.stojanovic@janeasystems.com>
StefanStojanovic
added
windows
StefanStojanovic
added
the
request-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My initial development for enabling PGO was done on a machine with Visual Studio 2026, where the code that landed works. However, it doesn't work with Visual Studio 2022 when cross-compiling for ARM64, because the
clang_rt.profile.libfor ARM64 is distributed under a different location in VS2022. This fix adds a fallback that ensures the needed lib is found when compiling with VS 2022 (our release configuration).Refs: #62761