test: disable Maglev in near-heap-limit worker test#63398
Open
trivikr wants to merge 1 commit into
Open
Conversation
The test expects the worker to run out of memory during startup while creating the message port. With Maglev enabled, the tiny worker heap can be exhausted earlier while generating deoptimization data, which changes the failure mode. Disable Maglev so the induced OOM reaches the path covered by the test. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63398 +/- ##
==========================================
+ Coverage 90.05% 90.06% +0.01%
==========================================
Files 714 714
Lines 225704 225704
Branches 42714 42726 +12
==========================================
+ Hits 203250 203291 +41
+ Misses 14225 14189 -36
+ Partials 8229 8224 -5 🚀 New features to boost your workflow:
|
aduh95
approved these changes
May 18, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
May 18, 2026
richardlau
approved these changes
May 18, 2026
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
added
the
author ready
Collaborator
trivikr
added
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a flaky failure in
test-worker-nearheaplimit-deadlockwhere theworker's intentionally tiny heap can be exhausted by Maglev compilation before
the test reaches the worker startup path it is meant to cover.
The test already disables snapshots because snapshot deserialization can hit
OOM too early. This applies the same idea to Maglev: disable it so the induced
OOM occurs during message port creation and is reported as
ERR_WORKER_OUT_OF_MEMORY.Refs:
Assisted-by: openai:gpt-5.5