Skip to content

test: deflake connection refused proxy tests #63395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trivikr wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −55
Open

test: deflake connection refused proxy tests #63395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 11 additions & 26 deletions test/client-proxy/test-http-proxy-request-connection-refused.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,34 +15,19 @@ await once(server, 'listening');
const serverHost = `localhost:${server.address().port}`;
const requestUrl = `http://${serverHost}/test`;

let maxRetries = 10;
let foundRefused = false;
while (maxRetries-- > 0) {
// Make it fail on connection refused by connecting to a port of a closed server.
// If it succeeds, get a different port and retry.
const proxy = http.createServer((req, res) => {
res.destroy();
});
proxy.listen(0);
await once(proxy, 'listening');
const port = proxy.address().port;
proxy.close();
await once(proxy, 'close');
const port = 10;
console.log(`Trying proxy at port ${port}`);
const { stderr } = await runProxiedRequest({
NODE_USE_ENV_PROXY: 1,
REQUEST_URL: requestUrl,
HTTP_PROXY: `http://127.0.0.1:${port}`,
NO_PROXY: '',
no_proxy: '',
REQUEST_TIMEOUT: 5000,
});

console.log(`Trying proxy at port ${port}`);
const { stderr } = await runProxiedRequest({
NODE_USE_ENV_PROXY: 1,
REQUEST_URL: requestUrl,
HTTP_PROXY: `http://localhost:${port}`,
REQUEST_TIMEOUT: 5000,
});

foundRefused = /Error.*connect ECONNREFUSED/.test(stderr);
if (foundRefused) {
// The proxy client should get a connection refused error.
break;
}
}
foundRefused = /Error.*connect ECONNREFUSED/.test(stderr);

server.close();
assert(foundRefused, 'Expected ECONNREFUSED error from proxy request');
42 changes: 13 additions & 29 deletions test/client-proxy/test-https-proxy-request-connection-refused.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import fixtures from '../common/fixtures.js';
import assert from 'node:assert';
import { once } from 'events';
import { runProxiedRequest } from '../common/proxy-server.js';
import http from 'node:http';

if (!common.hasCrypto)
common.skip('missing crypto');
Expand All @@ -25,35 +24,20 @@ await once(server, 'listening');
const serverHost = `localhost:${server.address().port}`;
const requestUrl = `https://${serverHost}/test`;

let maxRetries = 10;
let foundRefused = false;
while (maxRetries-- > 0) {
// Make it fail on connection refused by connecting to a port of a closed server.
// If it succeeds, get a different port and retry.
const proxy = http.createServer((req, res) => {
res.destroy();
});
proxy.listen(0);
await once(proxy, 'listening');
const port = proxy.address().port;
proxy.close();
await once(proxy, 'close');

console.log(`Trying proxy at port ${port}`);
const { stderr } = await runProxiedRequest({
NODE_USE_ENV_PROXY: 1,
REQUEST_URL: requestUrl,
HTTPS_PROXY: `http://localhost:${port}`,
NODE_EXTRA_CA_CERTS: fixtures.path('keys', 'fake-startcom-root-cert.pem'),
REQUEST_TIMEOUT: 5000,
});

foundRefused = /Error.*connect ECONNREFUSED/.test(stderr);
if (foundRefused) {
// The proxy client should get a connection refused error.
break;
}
}
const port = 10;
console.log(`Trying proxy at port ${port}`);
const { stderr } = await runProxiedRequest({
NODE_USE_ENV_PROXY: 1,
REQUEST_URL: requestUrl,
HTTPS_PROXY: `http://127.0.0.1:${port}`,
NO_PROXY: '',
no_proxy: '',
NODE_EXTRA_CA_CERTS: fixtures.path('keys', 'fake-startcom-root-cert.pem'),
REQUEST_TIMEOUT: 5000,
});

foundRefused = /Error.*connect ECONNREFUSED/.test(stderr);

server.close();
assert(foundRefused, 'Expected ECONNREFUSED error from proxy request');
Loading