doc: add Rust toolchain manual installation instructions Windows#63367
doc: add Rust toolchain manual installation instructions Windows#63367MikeMcC399 wants to merge 1 commit into
Conversation
Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
|
Review requested:
|
End-to-end testIn a PowerShell 7.6.1 admin terminal window: git clone https://github.com/nodejs/node
cd node
.\vcbuild.bat release msiEnsure Smart App Control is off In a new terminal window instance, execute: node -e "console.log(Temporal)"Confirm the output: |
mcollina
left a comment
There was a problem hiding this comment.
lgtm
I stumbled on this too.
|
To preview in the context of the full manual instructions for Windows https://github.com/MikeMcC399/node/blob/rust-on-windows-manual/BUILDING.md#option-1-manual-install |
|
This is only applicable to Node.js >=26. It's not necessary for earlier release lines. Due to the significant size of the Rust toolchain installation, this PR should probably be blocked from backporting to 22.x & 24.x from the point of view of additional network bandwidth and storage requirements, although it only concerns installation instructions. |
|
It's great to fill the gap in docs with this. We should also try to add this to the configurations, so that automated install is not broken as well. |
I did this separately in #63381. I only cross-linked it to #63225 though, so sorry if that wasn't clear! Are you planning any update to |
Refs: #63225
Situation
Windows prerequisites describe both manual install and WinGet install. These instructions do not cover Rust toolchain installation.
Change
Add
rustup-init.exeto the manual installation instructions with advice to select the standard (default) installation.Add this to Windows prerequisites - Manual install
Reference: https://rust-lang.github.io/rustup/index.html
Verification
On Windows 11 25H2 (amd64)
Install Visual Studio Build Tools 2022 (17.14.32) and follow other instructions in Windows prerequisites.
Download and run
rustup-init.exefrom https://rust-lang.org/tools/install/ and select default.Re-open terminal windows and check installation:
rustup logs
rust-lang/rustup#4744 is a known
rustupissue regarding spurious reporting of an existing config, even on a clean install.