fix(liquidity-sdk): use withdrawMarket in API query#731
Open
prd-carapulse[bot] wants to merge 1 commit into
Open
fix(liquidity-sdk): use withdrawMarket in API query#731prd-carapulse[bot] wants to merge 1 commit into
prd-carapulse[bot] wants to merge 1 commit into
Conversation
prd-carapulse
Bot
force-pushed
the
hermes/liquidity-sdk-withdraw-market
branch
from
2130cdb to
617294b
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
cc @Rubilmax To handle deprecation |
Rubilmax
previously approved these changes
May 27, 2026
Collaborator
|
@prd-carapulse[bot] include a patch changesets file in this pr and rebase on main |
Contributor
Author
|
API call failed after 3 retries: You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors. Track: https://carapulse.morpho.dev/dashboard/runs?run_id=gw_run_5dc452419860 |
Add patch changeset and rebase on latest main.
prd-carapulse
Bot
force-pushed
the
hermes/liquidity-sdk-withdraw-market
branch
from
6d808db to
617294b
Compare
prd-carapulse
Bot
force-pushed
the
hermes/liquidity-sdk-withdraw-market
branch
from
617294b to
6d808db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withdrawMarketinstead of deprecatedallocationMarketin@morpho-org/liquidity-sdk-viem.allocationMarketby aliasingwithdrawMarket, avoiding a public return-shape change.Request Context
milan@morpho.orgsearchmorpho-apifields marked deprecated withremovalAt: 2026-05-20.PublicAllocatorSharedLiquidity.allocationMarketusage before removal while preserving SDK compatibility.Verification
pnpm exec biome check packages/liquidity-sdk-viem/graphql/GetMarkets.query.gql packages/liquidity-sdk-viem/src/api/sdk.tsmorpho-api/schema.gql: noPublicAllocatorSharedLiquidity.allocationMarketwarning remains; unrelated existing warnings remain forMarket.targetBorrowUtilizationandMarket.targetWithdrawUtilization.pnpm --filter @morpho-org/liquidity-sdk-viem buildpnpm exec vitest run --project liquidity-sdk-viem packages/liquidity-sdk-viem/src/api/index.test.ts packages/liquidity-sdk-viem/src/loader.test.ts(15 tests passed)View Slack thread