This repository was archived by the owner on Oct 8, 2025. It is now read-only.
refactor(node-fetch-server): add type-safety to socket check in createRequest#75
Closed
MichaelDeBoey wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks, @MichaelDeBoey, but the code you wrote isn't really adding anything. The check is the same. |
Author
|
@mjackson The check is indeed the same, but it adds type-safety in the codebase by using type guards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Took inspiration from how React Router handles this check
https://github.com/remix-run/react-router/blob/87912477ce25a501f8cac71c1105dfe3b0bff5ca/packages/react-router-dev/vite/node-adapter.ts#L53-L55
This check was originally introduced in @TrySound's remix-run/remix#10199 and resubmitted in remix-run/react-router#13746
CC/ @mjackson