Add registry Key.get_bytes() method for reading REG_BINARY types#4410
Open
zanedp wants to merge 6 commits into
Open
Add registry Key.get_bytes() method for reading REG_BINARY types#4410zanedp wants to merge 6 commits into
zanedp wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reintroduces a safe, typed registry getter for REG_BINARY values (Type::Bytes) in windows-registry, addressing the regression noted in #3884.
Changes:
- Add
Key::get_bytes()to readREG_BINARY/Type::Bytesvalues asVec<u8>. - Extend the registry test suite to validate successful reads (including embedded zero bytes) and type-mismatch error behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/libs/registry/src/key.rs | Adds Key::get_bytes() typed getter for Type::Bytes registry values. |
| crates/tests/libs/registry/tests/bytes.rs | Adds coverage for get_bytes() success and failure cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Identified by Copilot's code review.
kennykerr
reviewed
May 12, 2026
| match ty { | ||
| Type::Bytes => { | ||
| let mut value = vec![0; sz]; | ||
| unsafe { self.raw_get_bytes(name.as_raw(), &mut value)? }; |
kennykerr
approved these changes
May 12, 2026
Collaborator
kennykerr
left a comment
kennykerr
left a comment
There was a problem hiding this comment.
Just nitpicks - looks great thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "safe" way to read registry values of type REG_BINARY.
Fixes: #3884