Skip to content

FIx 466: Show status messages for nuget package failures#486

Merged
nmetulev merged 6 commits into
mainfrom
zt/466-show-when-nuget-isnt-added
Apr 21, 2026
Merged

FIx 466: Show status messages for nuget package failures#486
nmetulev merged 6 commits into
mainfrom
zt/466-show-when-nuget-isnt-added

Conversation

@zateutsch
Copy link
Copy Markdown
Contributor

fixes #466

Show when nuget package installs fail and display to user instead of doing nothing.

Copilot AI review requested due to automatic review settings April 21, 2026 04:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Addresses #466 by ensuring winapp init surfaces NuGet package add failures to the user instead of always reporting success.

Changes:

  • Track non-required NuGet packages that fail to add during .NET project setup.
  • Update the subtask completion message to include a list of packages that failed to add (and optionally treat it as a failure when no packages were added).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/winapp-CLI/WinApp.Cli/Services/WorkspaceSetupService.cs Outdated
Comment thread src/winapp-CLI/WinApp.Cli/Services/WorkspaceSetupService.cs
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Build Metrics Report

Binary Sizes

Artifact Baseline Current Delta
CLI (ARM64) 30.65 MB 30.65 MB 📈 +0.5 KB (+0.00%)
CLI (x64) 31.02 MB 31.02 MB 📈 +1.0 KB (+0.00%)
MSIX (ARM64) 12.93 MB 12.93 MB 📈 +1.4 KB (+0.01%)
MSIX (x64) 13.74 MB 13.74 MB 📈 +0.5 KB (+0.00%)
NPM Package 26.89 MB 26.89 MB 📈 +1.7 KB (+0.01%)
NuGet Package 26.98 MB 26.98 MB 📈 +0.4 KB (+0.00%)
VS Code Extension 19.71 MB 19.71 MB 📈 +0.9 KB (+0.00%)

Test Results

771 passed out of 771 tests in 381.7s (+1 test, -8.3s vs. baseline)

Test Coverage

20.9% line coverage, 35.2% branch coverage · ✅ no change vs. baseline

CLI Startup Time

39ms median (x64, winapp --version) · ✅ -7ms vs. baseline


Updated 2026-04-21 16:49:37 UTC · commit 7e39eb7 · workflow run

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@nmetulev nmetulev enabled auto-merge (squash) April 21, 2026 15:54
@nmetulev nmetulev merged commit 9ace85d into main Apr 21, 2026
20 checks passed
@nmetulev nmetulev deleted the zt/466-show-when-nuget-isnt-added branch April 21, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: winapp init should show when a nuget package wasn't added

4 participants