Move agents window extension list to product.json#315683
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the sessions window extension allow-list from a hardcoded TS constant into product.json, so it can be configured as part of product configuration and consumed via IProductService.
Changes:
- Add
sessionsWindowAllowedExtensionsto the product configuration interface (IProductConfiguration). - Update
ExtensionEnablementServiceto read the allow-list fromIProductService(and normalize to lowercase). - Populate the allow-list in
product.json.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/services/extensionManagement/browser/extensionEnablementService.ts | Switch sessions-window allow-list source from a local constant to productService.sessionsWindowAllowedExtensions. |
| src/vs/base/common/product.ts | Extend IProductConfiguration with sessionsWindowAllowedExtensions?: readonly string[]. |
| product.json | Define the sessions window allow-list values in product configuration. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 1
dmitrivMS
approved these changes
May 11, 2026
benibenj
added
the
~release-cherry-pick
vs-code-engineering
Bot
added
release-cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Move the list of allowed extensions for the sessions window to theproduct.jsonconfiguration file and update the related TypeScript interfaces and services accordingly.