Skip to content

Manage Language Models: visibility-toggle focus loss no longer reproducible#315343

Closed
Copilot wants to merge 1 commit into
mainfrom
copilot/fix-keyboard-focus-issue
Closed

Manage Language Models: visibility-toggle focus loss no longer reproducible#315343
Copilot wants to merge 1 commit into
mainfrom
copilot/fix-keyboard-focus-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

The reported bug requires a Show/Hide (eye icon) action on each model row in the Manage Language Models editor — pressing Enter on a model toggled its visibility and dropped focus to the top of the list.

Investigation

  • That action and the entire model.visible plumbing were removed from chatModelsWidget.ts / chatModelsViewModel.ts / languageModels.ts in commit 40e150fc96a ("Remove model picker visibility overrides").
  • In current main, table.onDidOpen only toggles collapse for vendor/group entries; pressing Enter on a model row is a no-op, so no splice/refocus occurs.
  • No remaining surface in the manage-models editor changes per-model visibility, so the repro is dead.

Changes

  • None. Closing as not actionable against main. If a similar visibility toggle is reintroduced, the splice handler at chatModelsWidget.ts ~L1250 already restores focus via viewModel.selectedEntry — any new toggle just needs to set selectedEntry before mutating the model list.

Copilot AI requested review from Copilot and removed request for Copilot May 8, 2026 19:07
Copilot AI linked an issue May 8, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix keyboard focus loss when toggling model visibility Manage Language Models: visibility-toggle focus loss no longer reproducible May 8, 2026
Copilot AI requested a review from meganrogge May 8, 2026 19:16
@meganrogge meganrogge added this to the 1.121.0 milestone May 8, 2026
@meganrogge meganrogge closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Making models hidden or visible loses keyboard focus

2 participants