Manage Language Models: visibility-toggle focus loss no longer reproducible#315343
Closed
Copilot wants to merge 1 commit into
Closed
Manage Language Models: visibility-toggle focus loss no longer reproducible#315343Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Copilot
AI
changed the title
[WIP] Fix keyboard focus loss when toggling model visibility
Manage Language Models: visibility-toggle focus loss no longer reproducible
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reported bug requires a Show/Hide (eye icon) action on each model row in the Manage Language Models editor — pressing Enter on a model toggled its visibility and dropped focus to the top of the list.
Investigation
model.visibleplumbing were removed fromchatModelsWidget.ts/chatModelsViewModel.ts/languageModels.tsin commit40e150fc96a("Remove model picker visibility overrides").main,table.onDidOpenonly toggles collapse for vendor/group entries; pressing Enter on a model row is a no-op, so no splice/refocus occurs.Changes
main. If a similar visibility toggle is reintroduced, the splice handler atchatModelsWidget.ts~L1250 already restores focus viaviewModel.selectedEntry— any new toggle just needs to setselectedEntrybefore mutating the model list.