Make appearedInsideViewport in InlineCompletionsModel reactive (#289944)#289946
Merged
benibenj merged 1 commit intoMay 13, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where users had to press Tab twice to accept an inline completion suggestion that was initially outside the viewport but scrolled into view. The fix makes the _appearedInsideViewport observable properly reactive to viewport changes by passing the reader parameter to isSuggestionInViewport.
Changes:
- Made
_appearedInsideViewportreactive to viewport changes by passing thereaderparameter toisSuggestionInViewport
yavanosta
force-pushed
the
InlineCompletionsModel-appearedInsideViewport-not-reactive
branch
from
d0cd0d7 to
98e320c
Compare
Contributor
|
Let's give it a try. I won't merge it before monday to make sure it's not in next weeks release but the week after so it's tested on insiders for a couple of days. Please ping me if I forget to merge it |
benibenj
approved these changes
May 8, 2026
alexdima
approved these changes
May 8, 2026
Contributor
Author
benibenj Ping! :) |
Contributor
|
pipeline was stuck. Retrying |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes _appearedInsideViewport reactive.
Fixed #289944