Add Change Connection to SQL editor context menu#22098
Open
aasimkhan30 wants to merge 1 commit into
Open
Conversation
aasimkhan30
requested review from
Benjin,
allancascante,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez and
ssreerama
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the existing mssql.changeConnection command to the SQL editor’s right-click context menu, improving discoverability and making it easier to switch connections directly from an open .sql editor tab (per #20383).
Changes:
- Contributes
mssql.changeConnectionto theeditor/contextmenu for SQL editors. - Gates visibility to appropriate states (not diff editor, connected resource, not running a query, UI not hidden).
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22098 +/- ##
=======================================
Coverage 74.83% 74.83%
=======================================
Files 394 394
Lines 120403 120403
Branches 7197 7197
=======================================
Hits 90102 90102
Misses 30301 30301
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the existing
mssql.changeConnectioncommand to the SQL editor right-click context menu so users can switch connections from an open editor tab without using the command palette.Fixes #20383
Validation:
extensions/mssql/package.jsonwith Node to verify the manifest remains valid JSON.Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines