Skip to content

Remove SQL notebook preview tags#22066

Merged
lewis-sanchez merged 2 commits into
mainfrom
lewissanchez/sql-notebooks/remove-preview-tags
May 7, 2026
Merged

Remove SQL notebook preview tags#22066
lewis-sanchez merged 2 commits into
mainfrom
lewissanchez/sql-notebooks/remove-preview-tags

Conversation

@lewis-sanchez
Copy link
Copy Markdown
Contributor

@lewis-sanchez lewis-sanchez commented May 6, 2026

Description

This PR removes the preview tags that appear in the two entry points to make a new SQL notebook. Here's the updated context menu option:

  1. OE Context Menu Item
image

2. Command Palette: image

Provide a clear, concise summary of the changes in this PR. What problem does it solve? Why is it needed? Link any related issues using issue closing keywords.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Copilot AI review requested due to automatic review settings May 6, 2026 18:49
@lewis-sanchez lewis-sanchez changed the title Remove preview tags appearing in SQL notebook entry points Remove SQL notebook preview tags May 6, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the MSSQL extension’s localized command title for creating a SQL notebook to remove the “(Preview)” suffix, ensuring both the Object Explorer context menu entry and the Command Palette entry display the non-preview label.

Changes:

  • Updated the mssql.notebooks.createNotebook localization string from “New SQL Notebook (Preview)” to “New SQL Notebook”.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 78061 KB 78061 KB ⚪ 0 KB ( 0% )
sql-database-projects VSIX 6309 KB 6309 KB ⚪ 0 KB ( 0% )
data-workspace VSIX 535 KB 535 KB ⚪ 0 KB ( 0% )
keymap VSIX 7 KB 7 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.95%. Comparing base (b4542ac) to head (417b3b3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #22066   +/-   ##
=======================================
  Coverage   74.95%   74.95%           
=======================================
  Files         393      393           
  Lines      119869   119869           
  Branches     7161     7161           
=======================================
  Hits        89847    89847           
  Misses      30022    30022           
Flag Coverage Δ
data-workspace 77.10% <ø> (ø)
mssql 74.64% <ø> (ø)
sqlproj 77.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lewis-sanchez lewis-sanchez merged commit 2a55c35 into main May 7, 2026
3 checks passed
@lewis-sanchez lewis-sanchez deleted the lewissanchez/sql-notebooks/remove-preview-tags branch May 7, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants