Fix package-extension to work on Windows#22006
Open
kburtram wants to merge 1 commit into
Open
Conversation
kburtram
requested review from
Benjin,
aasimkhan30,
allancascante,
caohai,
laurenastrid1,
lewis-sanchez and
ssreerama
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the extensions/mssql packaging script so it can successfully invoke npm.cmd on Windows when running vsce package, aligning behavior with how Windows command shims need to be launched from Node.
Changes:
- Run
execFileSyncwithshell: trueon Windows when invokingnpm.cmdfor extension packaging.
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22006 +/- ##
=======================================
Coverage 74.88% 74.88%
=======================================
Files 393 393
Lines 119260 119260
Branches 7083 7083
=======================================
Hits 89305 89305
Misses 29955 29955
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
aasimkhan30
approved these changes
Apr 24, 2026
Benjin
approved these changes
Apr 24, 2026
lewis-sanchez
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
shell: trueoption is required when launching a.cmdwith Node spawn. This updates package-extension to work properly on Windows.