Fix operator precedence in Object Explorer context menu when conditions#21505
Closed
Copilot wants to merge 2 commits into
Closed
Fix operator precedence in Object Explorer context menu when conditions#21505Copilot wants to merge 2 commits into
when conditions#21505Copilot wants to merge 2 commits into
Conversation
5 tasks
Co-authored-by: Benjin <1609827+Benjin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on OE context menu organization
Fix operator precedence in Object Explorer context menu Mar 6, 2026
when conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three OE context menu
whenconditions had a&&/||precedence bug causingview == objectExplorerto only guard thetyperegex, not thesubTyperegex — so commands appeared outside the Object Explorer wheneversubTypematched.Before (broken):
Parsed as
(view == objectExplorer && type check) || (subType check)— subType branch has no view guard.After (fixed):
Affected commands:
mssql.searchDatabasemssql.restoreDatabasemssql.flatFileImportCode Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.