Fix operator precedence in OE context menu when clauses for Database/DockerContainerDatabase nodes#21504
Merged
Merged
Conversation
5 tasks
…ase nodes Co-authored-by: Benjin <1609827+Benjin@users.noreply.github.com>
Benjin
approved these changes
Mar 6, 2026
Copilot
AI
changed the title
[WIP] WIP addressing feedback on OE context menu organization
Fix operator precedence in OE context menu Mar 6, 2026
when clauses for Database/DockerContainerDatabase nodes
Benjin
requested review from
aasimkhan30,
allancascante,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez,
manujoseph85 and
ssreerama
as code owners
Benjin
added a commit
that referenced
this pull request
Mar 7, 2026
* Menu updates * Loc * Removing backup from server (not valid entrypoint) * Loc * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix operator precedence in OE context menu `when` clauses for Database/DockerContainerDatabase nodes (#21504) * Initial plan * Fix when clause operator precedence for Database/DockerContainerDatabase nodes Co-authored-by: Benjin <1609827+Benjin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Benjin <1609827+Benjin@users.noreply.github.com> * Updating labels --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three
whenclauses inpackage.jsonmixed&&and||without parentheses, causingview == objectExplorerto only gate the first branch of the OR — thesubTypebranch was visible outside Object Explorer.Affected commands:
mssql.searchDatabase,mssql.restoreDatabase,mssql.flatFileImportBefore:
After:
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.